Issue 10873101: Revert 153571 - Create base class for TabHelpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10873101: Revert 153571 - Create base class for TabHelpers. (Closed)

Created:
8 years, 3 months ago by alexeypa (please no reviews)

Modified:
8 years, 3 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 153571 - Create base class for TabHelpers. WebContentsUserDataTest.BasicTest is flaky. BUG=107201 TEST=none Review URL: https://chromiumcodereview.appspot.com/10868115 TBR=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153591

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -94 lines)			Patch
D	chrome/browser/tab_contents/web_contents_user_data.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	chrome/browser/tab_contents/web_contents_user_data_unittest.cc	View	1 chunk	+0 lines, -55 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

alexeypa (please no reviews)

8 years, 3 months ago (2012-08-28 00:14:50 UTC) #2

On 2012/08/28 00:13:50, alexeypa wrote:

http://chromegw.corp.google.com/i/chromium/builders/Vista%20Tests%20%283%29/b...

http://chromegw.corp.google.com/i/chromium/builders/Vista%20Tests%20%283%29/b...

Expand Messages | Collapse Messages