Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10873095: *v8::String::Utf8Value can return NULL. (Closed)

Created:
8 years, 3 months ago by Aaron Boodman
Modified:
8 years, 3 months ago
Reviewers:
eaugusti, Yoyo Zhou, jam
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

*v8::String::Utf8Value can return NULL. BUG=144436

Patch Set 1 #

Patch Set 2 : more better #

Total comments: 1

Patch Set 3 : add handlescope #

Patch Set 4 : whoops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/renderer/module_system.cc View 1 2 3 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Aaron Boodman
8 years, 3 months ago (2012-08-27 22:20:42 UTC) #1
eaugusti
lgtm
8 years, 3 months ago (2012-08-27 22:26:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/10873095/3002
8 years, 3 months ago (2012-08-27 22:29:28 UTC) #3
commit-bot: I haz the power
Presubmit check for 10873095-3002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-08-27 22:29:34 UTC) #4
Yoyo Zhou
LGTM
8 years, 3 months ago (2012-08-27 22:35:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/10873095/3002
8 years, 3 months ago (2012-08-27 22:39:02 UTC) #6
commit-bot: I haz the power
Presubmit check for 10873095-3002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-08-27 22:39:14 UTC) #7
eaugusti
https://chromiumcodereview.appspot.com/10873095/diff/3002/chrome/renderer/module_system.cc File chrome/renderer/module_system.cc (right): https://chromiumcodereview.appspot.com/10873095/diff/3002/chrome/renderer/module_system.cc#newcode82 chrome/renderer/module_system.cc:82: v8::String::Utf8Value stack_value(try_catch.StackTrace()); I think this should be v8::Handle<v8::String::Utf8Value>, and ...
8 years, 3 months ago (2012-08-27 22:39:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/10873095/3002
8 years, 3 months ago (2012-08-27 22:48:38 UTC) #9
commit-bot: I haz the power
Presubmit check for 10873095-3002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-08-27 22:48:41 UTC) #10
jam
lgtm
8 years, 3 months ago (2012-08-27 23:30:34 UTC) #11
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 23:35:22 UTC) #12

Powered by Google App Engine
This is Rietveld 408576698