Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Issue 10873094: alternate ntp: fix toolbar separator visibility when query is cleared (Closed)

Created:
8 years, 3 months ago by kuan
Modified:
8 years, 3 months ago
Reviewers:
sky, dhollowa
CC:
chromium-reviews, dhollowa+watch_chromium.org
Visibility:
Public.

Description

alternate ntp: fix toolbar separator visibility when query is cleared - when query is cleared, suggestions disappear, but toolbar separator still shouldn't show up - fix to only show separator in SUGGESTIONS mode when user input is not in progress BUG=144764 TEST=verify per bug rpt Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M chrome/browser/ui/browser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_delegate.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_delegate.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/toolbar_search_animator.h View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/search/toolbar_search_animator.cc View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kuan
8 years, 3 months ago (2012-08-27 22:08:03 UTC) #1
dhollowa
lgtm
8 years, 3 months ago (2012-08-27 22:35:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kuan@chromium.org/10873094/1
8 years, 3 months ago (2012-08-27 22:40:37 UTC) #3
commit-bot: I haz the power
Presubmit check for 10873094-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-08-27 22:40:49 UTC) #4
kuan
scott, cld u pls review for owners' approval? thx.
8 years, 3 months ago (2012-08-27 22:41:21 UTC) #5
sky
LGTM
8 years, 3 months ago (2012-08-27 23:59:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kuan@chromium.org/10873094/1
8 years, 3 months ago (2012-08-28 00:00:33 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-08-28 03:08:58 UTC) #8
Change committed as 153614

Powered by Google App Engine
This is Rietveld 408576698