Issue 10873082: Converted policy.PolicyTest.ClearSiteDataOnExit pyauto test to a browser_test.

Issue 10873082: Converted policy.PolicyTest.ClearSiteDataOnExit pyauto test to a browser_test. (Closed)

Created:
8 years, 3 months ago by Joao da Silva

Modified:
8 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Converted policy.PolicyTest.ClearSiteDataOnExit pyauto test to a browser_test. BUG=143637 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153529

Patch Set 2 : Moved cookie code to browser_test_utils #

Patch Set 3 : . #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -29 lines)			Patch
M	chrome/browser/policy/policy_browsertest.cc	View	1	4 chunks	+39 lines, -0 lines	0 comments	Download
M	chrome/test/functional/policy.py	View		1 chunk	+0 lines, -26 lines	0 comments	Download
M	content/public/test/browser_test_utils.h	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
M	content/public/test/browser_test_utils.cc	View	1	2 chunks	+36 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jam

thanks for the help! http://codereview.chromium.org/10873082/diff/1/chrome/browser/policy/policy_browsertest.cc File chrome/browser/policy/policy_browsertest.cc (right): http://codereview.chromium.org/10873082/diff/1/chrome/browser/policy/policy_browsertest.cc#newcode74 chrome/browser/policy/policy_browsertest.cc:74: void GetCookieOnIOThread( see r153484 which ...

8 years, 3 months ago (2012-08-27 17:02:04 UTC) #2

Joao da Silva

http://codereview.chromium.org/10873082/diff/1/chrome/browser/policy/policy_browsertest.cc File chrome/browser/policy/policy_browsertest.cc (right): http://codereview.chromium.org/10873082/diff/1/chrome/browser/policy/policy_browsertest.cc#newcode74 chrome/browser/policy/policy_browsertest.cc:74: void GetCookieOnIOThread( On 2012/08/27 17:02:04, John Abd-El-Malek wrote: > ...

8 years, 3 months ago (2012-08-27 17:39:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10873082/1005

8 years, 3 months ago (2012-08-27 17:53:24 UTC) #5

Change committed as 153529

Expand Messages | Collapse Messages