Rename SystemMonitor's MediaDevice calls to RemovableStorage.

Rename SystemMonitor's MediaDevice calls to RemovableStorage. Functional changes to follow in future CLs.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153428

[vandebo (ex-Chrome), 2012-08-25 00:58:10]

LGTM

https://chromiumcodereview.appspot.com/10873072/diff/5003/base/system_monitor...
File base/system_monitor/system_monitor.h (right):

https://chromiumcodereview.appspot.com/10873072/diff/5003/base/system_monitor...
base/system_monitor/system_monitor.h:67: std::string unique_id;
nit: while you're here, can you make this device_id?  I've been trying to use
device_id to be a fully qualified id (with the type information) and unique_id
to be just the unique_id within the type.

https://chromiumcodereview.appspot.com/10873072/diff/5003/base/system_monitor...
base/system_monitor/system_monitor.h:96: // Returns information for attached
removable storages.
nit: storages? Storage is generally both plural and singular.

[Lei Zhang, 2012-08-25 01:12:26]

https://chromiumcodereview.appspot.com/10873072/diff/5003/base/system_monitor...
File base/system_monitor/system_monitor.h (right):

https://chromiumcodereview.appspot.com/10873072/diff/5003/base/system_monitor...
base/system_monitor/system_monitor.h:67: std::string unique_id;
On 2012/08/25 00:58:10, vandebo wrote:
> nit: while you're here, can you make this device_id?  I've been trying to use
> device_id to be a fully qualified id (with the type information) and unique_id
> to be just the unique_id within the type.

Done.

https://chromiumcodereview.appspot.com/10873072/diff/5003/base/system_monitor...
base/system_monitor/system_monitor.h:96: // Returns information for attached
removable storages.
On 2012/08/25 00:58:10, vandebo wrote:
> nit: storages? Storage is generally both plural and singular.

Done.

[commit-bot: I haz the power, 2012-08-25 01:24:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/10873072/3004

[commit-bot: I haz the power, 2012-08-25 01:24:20]

Presubmit check for 10873072-3004 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base
    base/test

Presubmit checks took 1.5s to calculate.

[Lei Zhang, 2012-08-25 01:26:02]

+willchan for base OWNERS

[willchan no longer on Chromium, 2012-08-26 20:46:12]

lgtm

[commit-bot: I haz the power, 2012-08-26 20:46:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/10873072/3004

[commit-bot: I haz the power, 2012-08-26 23:00:33]

Change committed as 153428