Issue 10873064: remove old createMediaPlayer which doesn't have URL as argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10873064: remove old createMediaPlayer which doesn't have URL as argument. (Closed)

Created:
8 years, 4 months ago by wjia(left Chromium)

Modified:
8 years, 4 months ago

Reviewers:
jamesr, scherkus (not reviewing)

CC:
chromium-reviews, joi+watch-content_chromium.org, pam+watch_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

remove old createMediaPlayer which doesn't have URL as argument. Since WebKit patch has been landed (WebKit r126463), createMediaPlayer without URL as argument is not needed any more. BUG=142988 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153286

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -46 lines)			Patch
M	content/renderer/render_view_impl.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	webkit/support/webkit_support.h	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

wjia(left Chromium)

This patch removes TODO's since WebKit patch has been landed.

8 years, 4 months ago (2012-08-24 17:39:30 UTC) #1

lgtm