Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 10873062: Fix sync unit test. (Closed)

Created:
8 years, 4 months ago by qsr
Modified:
8 years, 3 months ago
Reviewers:
rlarocque
CC:
chromium-reviews
Visibility:
Public.

Description

Fix sync unit test. OnDiskSyncableDirectory::FailInitialWrite was using a ScopedTempDir without calling any Create method. TEST=None BUG=144537, 144422 R=rlarocque@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sync/syncable/syncable_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qsr
8 years, 4 months ago (2012-08-24 13:35:35 UTC) #1
rlarocque
Thanks! I'd been meaning to look into this, but haven't had the time. I'm guessing ...
8 years, 4 months ago (2012-08-24 17:38:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/10873062/1
8 years, 3 months ago (2012-08-27 07:34:21 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 10:51:35 UTC) #4
Change committed as 153461

Powered by Google App Engine
This is Rietveld 408576698