Added IC support for native setters on the prototype chain.

Added IC support for native setters on the prototype chain.

Committed: https://code.google.com/p/v8/source/detail?r=12402

[ulan, 2012-08-28 08:11:19]

LGTM

http://codereview.chromium.org/10873057/diff/1/src/mips/stub-cache-mips.cc
File src/mips/stub-cache-mips.cc (right):

http://codereview.chromium.org/10873057/diff/1/src/mips/stub-cache-mips.cc#ne...
src/mips/stub-cache-mips.cc:2695: if (receiver->IsJSGlobalProxy()) {
CheckPrototype() does the same check for holder. Do we need it for receiver
here?

[Sven Panne, 2012-08-28 08:30:01]

I have removed a superfluous CheckAccessGlobalProxy call and changed the  ASSERT
to use the holder, but I am not 100% sure if this is the right thing to do.

Added Erik and Slava as reviewers, hopefully they know more about
CheckAccessGlobalProxy than we do here in Munich... :-)

[Erik Corry, 2012-08-29 10:46:48]

LGTM

http://codereview.chromium.org/10873057/diff/8002/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/10873057/diff/8002/src/ic.cc#newcode1327
src/ic.cc:1327: // that we explicitly exclude native accessors for now, because
the stubs
This comment is still valid?

[Sven Panne, 2012-08-30 06:38:47]

http://codereview.chromium.org/10873057/diff/8002/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/10873057/diff/8002/src/ic.cc#newcode1327
src/ic.cc:1327: // that we explicitly exclude native accessors for now, because
the stubs
On 2012/08/29 10:46:48, Erik Corry wrote:
> This comment is still valid?

Ooops, of course not, I'll submit a tiny CL to fix the comment...