Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 10873057: Added IC support for native setters on the prototype chain. (Closed)

Created:
8 years, 4 months ago by Sven Panne
Modified:
8 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added IC support for native setters on the prototype chain. Committed: https://code.google.com/p/v8/source/detail?r=12402

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased and removed superfluous checks #

Patch Set 3 : Rebased #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -66 lines) Patch
M src/arm/stub-cache-arm.cc View 1 2 chunks +9 lines, -15 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 3 chunks +12 lines, -15 lines 0 comments Download
M src/ic.cc View 2 chunks +3 lines, -4 lines 2 comments Download
M src/mips/stub-cache-mips.cc View 1 2 chunks +8 lines, -13 lines 0 comments Download
M src/stub-cache.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/stub-cache.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 chunks +9 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sven Panne
8 years, 4 months ago (2012-08-24 07:56:58 UTC) #1
Sven Panne
8 years, 3 months ago (2012-08-27 07:08:09 UTC) #2
ulan
LGTM http://codereview.chromium.org/10873057/diff/1/src/mips/stub-cache-mips.cc File src/mips/stub-cache-mips.cc (right): http://codereview.chromium.org/10873057/diff/1/src/mips/stub-cache-mips.cc#newcode2695 src/mips/stub-cache-mips.cc:2695: if (receiver->IsJSGlobalProxy()) { CheckPrototype() does the same check ...
8 years, 3 months ago (2012-08-28 08:11:19 UTC) #3
Sven Panne
I have removed a superfluous CheckAccessGlobalProxy call and changed the ASSERT to use the holder, ...
8 years, 3 months ago (2012-08-28 08:30:01 UTC) #4
Erik Corry
LGTM http://codereview.chromium.org/10873057/diff/8002/src/ic.cc File src/ic.cc (right): http://codereview.chromium.org/10873057/diff/8002/src/ic.cc#newcode1327 src/ic.cc:1327: // that we explicitly exclude native accessors for ...
8 years, 3 months ago (2012-08-29 10:46:48 UTC) #5
Sven Panne
8 years, 3 months ago (2012-08-30 06:38:47 UTC) #6
http://codereview.chromium.org/10873057/diff/8002/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/10873057/diff/8002/src/ic.cc#newcode1327
src/ic.cc:1327: // that we explicitly exclude native accessors for now, because
the stubs
On 2012/08/29 10:46:48, Erik Corry wrote:
> This comment is still valid?

Ooops, of course not, I'll submit a tiny CL to fix the comment...

Powered by Google App Engine
This is Rietveld 408576698