Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 10873047: Renamed Decoder -> VideoDecoder. (Closed)

Created:
8 years, 4 months ago by kxing
Modified:
8 years, 4 months ago
Reviewers:
Sergey Ulanov, garykac, Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Renamed Decoder -> VideoDecoder. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153140

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -90 lines) Patch
M remoting/client/rectangle_update_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/rectangle_update_decoder.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/codec/codec_test.h View 2 chunks +3 lines, -3 lines 2 comments Download
M remoting/codec/codec_test.cc View 10 chunks +17 lines, -17 lines 0 comments Download
M remoting/codec/video_decoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/codec/video_decoder_row_based.h View 3 chunks +8 lines, -8 lines 0 comments Download
M remoting/codec/video_decoder_row_based.cc View 6 chunks +22 lines, -21 lines 0 comments Download
M remoting/codec/video_decoder_vp8.h View 2 chunks +5 lines, -5 lines 0 comments Download
M remoting/codec/video_decoder_vp8.cc View 4 chunks +14 lines, -13 lines 0 comments Download
M remoting/codec/video_decoder_vp8_unittest.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M remoting/codec/video_encode_decode_unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kxing
Could someone PTAL?
8 years, 4 months ago (2012-08-23 21:26:41 UTC) #1
Wez
lgtm http://codereview.chromium.org/10873047/diff/1/remoting/codec/codec_test.h File remoting/codec/codec_test.h (right): http://codereview.chromium.org/10873047/diff/1/remoting/codec/codec_test.h#newcode15 remoting/codec/codec_test.h:15: class Encoder; Will you rename Encoder in a ...
8 years, 4 months ago (2012-08-23 21:44:44 UTC) #2
kxing
I'll commit this soon, unless someone objects. http://codereview.chromium.org/10873047/diff/1/remoting/codec/codec_test.h File remoting/codec/codec_test.h (right): http://codereview.chromium.org/10873047/diff/1/remoting/codec/codec_test.h#newcode15 remoting/codec/codec_test.h:15: class Encoder; ...
8 years, 4 months ago (2012-08-23 21:45:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kxing@chromium.org/10873047/1
8 years, 4 months ago (2012-08-23 23:17:06 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-24 01:47:39 UTC) #5
Change committed as 153140

Powered by Google App Engine
This is Rietveld 408576698