Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: net/dns/dns_config_service_win.h

Issue 10873018: [net] Move DnsConfigService to NetworkChangeNotifier. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add comment Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/dns/dns_config_service_unittest.cc ('k') | net/dns/dns_config_service_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/dns_config_service_win.h
diff --git a/net/dns/dns_config_service_win.h b/net/dns/dns_config_service_win.h
index b0a29d0d6698e2db95b2f893ea32a22cde42e9af..e036e44081d09b0aa3ef9fbf649485f5ca604548 100644
--- a/net/dns/dns_config_service_win.h
+++ b/net/dns/dns_config_service_win.h
@@ -122,25 +122,24 @@ ConfigParseWinResult NET_EXPORT_PRIVATE ConvertSettingsToDnsConfig(
DnsConfig* dns_config);
// Use DnsConfigService::CreateSystemService to use it outside of tests.
-class NET_EXPORT_PRIVATE DnsConfigServiceWin
- : public DnsConfigService,
- public NetworkChangeNotifier::IPAddressObserver {
+class NET_EXPORT_PRIVATE DnsConfigServiceWin : public DnsConfigService {
public:
DnsConfigServiceWin();
virtual ~DnsConfigServiceWin();
- virtual void Watch(const CallbackType& callback) OVERRIDE;
-
private:
+ class Watcher;
class ConfigReader;
class HostsReader;
- // NetworkChangeNotifier::DNSObserver:
- virtual void OnDNSChanged(unsigned detail) OVERRIDE;
+ // DnsConfigService:
+ virtual void ReadNow() OVERRIDE;
+ virtual bool StartWatching() OVERRIDE;
- // NetworkChangeNotifier::IPAddressObserver:
- virtual void OnIPAddressChanged() OVERRIDE;
+ void OnConfigChanged(bool succeeded);
+ void OnHostsChanged(bool succeeded);
+ scoped_ptr<Watcher> watcher_;
scoped_refptr<ConfigReader> config_reader_;
scoped_refptr<HostsReader> hosts_reader_;
« no previous file with comments | « net/dns/dns_config_service_unittest.cc ('k') | net/dns/dns_config_service_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698