Issue 10872104: Make sure MockHostResolverWorks regardless of whether winsock has already been initialized yet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10872104: Make sure MockHostResolverWorks regardless of whether winsock has already been initialized yet. (Closed)

Created:
8 years, 3 months ago by eroman

Modified:
8 years, 3 months ago

Reviewers:
szym

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Make sure MockHostResolverWorks regardless of whether winsock has already been initialized yet. BUG=145125 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153707

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	net/base/mock_host_resolver.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

eroman

alternately i could move initialization into mockhostresolver, i don't have a strong preference.

8 years, 3 months ago (2012-08-28 01:30:01 UTC) #1

szym

On 2012/08/28 01:30:01, eroman wrote: > alternately i could move initialization into mockhostresolver, i don't ...

8 years, 3 months ago (2012-08-28 01:51:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/10872104/4001

8 years, 3 months ago (2012-08-28 16:44:21 UTC) #5

Change committed as 153707