ash: Add support for additional icons in apps search list.

ash: Add support for additional icons in apps search list.

This adds the concept of "action icons" to
app_list::SearchResult.  These are small icons that appear
at the right of a given search result and can be clicked to
invoke alternate actions.  I'm planning to use this to
expose chat, call, email, etc. actions for contact results.

BUG=141877
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153795

[Daniel Erat, 2012-08-27 23:16:51]

Hi Xiyuan, please let me know if this approach seems reasonable.  I'll be in MTV
tomorrow, so I can come by to talk about the change.

https://chromiumcodereview.appspot.com/10872099/diff/1/ui/app_list/search_res...
File ui/app_list/search_result_view.cc (right):

https://chromiumcodereview.appspot.com/10872099/diff/1/ui/app_list/search_res...
ui/app_list/search_result_view.cc:262: image =
gfx::ImageSkiaOperations::CreateResizedImage(
I can take this out if you were intentionally using faster, lower-quality
scaling (there were performance issues with the old app list, right?).  Contact
photos look pretty bad without it, though, so maybe I should add a flag to
SearchResult controlling whether we do this...

[xiyuan, 2012-08-28 01:01:49]

LGTM

http://codereview.chromium.org/10872099/diff/1/ui/app_list/search_result.h
File ui/app_list/search_result.h (right):

http://codereview.chromium.org/10872099/diff/1/ui/app_list/search_result.h#ne...
ui/app_list/search_result.h:90: void SetActionIcons(const
std::vector<ActionIconSet>& sets);
nit: Use ActionIconSets typedef'd above?

http://codereview.chromium.org/10872099/diff/1/ui/app_list/search_result_view.cc
File ui/app_list/search_result_view.cc (right):

http://codereview.chromium.org/10872099/diff/1/ui/app_list/search_result_view...
ui/app_list/search_result_view.cc:176: rect.width() - kActionButtonRightMargin -
nit: rect.width() -> rect.right()

Currently it is okay since we don't have insets thus rect.width() ==
rect.right(). But think right is more correct here.

http://codereview.chromium.org/10872099/diff/1/ui/app_list/search_result_view...
ui/app_list/search_result_view.cc:178: (rect.height() - kActionIconDimension) /
2,
nit: similar to above, add "rect.y() +" so that it works when we have insets.

http://codereview.chromium.org/10872099/diff/1/ui/app_list/search_result_view...
ui/app_list/search_result_view.cc:262: image =
gfx::ImageSkiaOperations::CreateResizedImage(
Think your change is better than old code. The performance issue is with the
grid view where we have much more icons there.

[Daniel Erat, 2012-08-28 16:45:37]

http://codereview.chromium.org/10872099/diff/1/ui/app_list/search_result.h
File ui/app_list/search_result.h (right):

http://codereview.chromium.org/10872099/diff/1/ui/app_list/search_result.h#ne...
ui/app_list/search_result.h:90: void SetActionIcons(const
std::vector<ActionIconSet>& sets);
On 2012/08/28 01:01:49, xiyuan wrote:
> nit: Use ActionIconSets typedef'd above?

Whoops, done.

http://codereview.chromium.org/10872099/diff/1/ui/app_list/search_result_view.cc
File ui/app_list/search_result_view.cc (right):

http://codereview.chromium.org/10872099/diff/1/ui/app_list/search_result_view...
ui/app_list/search_result_view.cc:176: rect.width() - kActionButtonRightMargin -
On 2012/08/28 01:01:49, xiyuan wrote:
> nit: rect.width() -> rect.right()
> 
> Currently it is okay since we don't have insets thus rect.width() ==
> rect.right(). But think right is more correct here.

Done.

http://codereview.chromium.org/10872099/diff/1/ui/app_list/search_result_view...
ui/app_list/search_result_view.cc:178: (rect.height() - kActionIconDimension) /
2,
On 2012/08/28 01:01:49, xiyuan wrote:
> nit: similar to above, add "rect.y() +" so that it works when we have insets.

Done.

[commit-bot: I haz the power, 2012-08-28 19:25:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10872099/11003

[commit-bot: I haz the power, 2012-08-28 23:48:17]

Change committed as 153795