Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 10872093: Refactor SelectFaviconFrames to make it easy to use SelectFaviconFrameson objects other than bitmaps (Closed)

Created:
8 years, 3 months ago by pkotwicz
Modified:
8 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, sky, stevenjb, rjkroege
Visibility:
Public.

Description

Refactor SelectFaviconFrames to make it easy to use SelectFaviconFrames on objects other than SkBitmaps. Changed the selection and score calculation code to operate on std::vector<gfx::Size> instead of an std::vector<SkBitmap>. Bug=10802066 Test=SelectFaviconFramesTest.* pass TBR=thakis Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153590

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -53 lines) Patch
M chrome/browser/favicon/select_favicon_frames.cc View 1 4 chunks +136 lines, -53 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
Refactor SelectFaviconFrames to make it easy to use SelectFaviconFrames on objects other than SkBitmaps. Changed ...
8 years, 3 months ago (2012-08-27 20:36:50 UTC) #1
pkotwicz
Codereview moved from https://chromiumcodereview.appspot.com/10883056/
8 years, 3 months ago (2012-08-27 20:38:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10872093/1
8 years, 3 months ago (2012-08-27 20:40:05 UTC) #3
commit-bot: I haz the power
Try job failure for 10872093-1 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 3 months ago (2012-08-27 21:10:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10872093/1003
8 years, 3 months ago (2012-08-27 21:49:32 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-08-28 00:11:17 UTC) #6
Change committed as 153590

Powered by Google App Engine
This is Rietveld 408576698