src/variables.cc - Issue 10872084: Allocate block-scoped global bindings to global context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/variables.cc

Issue 10872084: Allocate block-scoped global bindings to global context. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/variables.cc

diff --git a/src/variables.cc b/src/variables.cc

index 32ad5bc5dd4d09329ed1bd702106d3e0ee6dbcf9..64311d925d92c16bd04a6a2316a69b1db0e7d814 100644

--- a/src/variables.cc

+++ b/src/variables.cc

@@ -81,10 +81,11 @@ Variable::Variable(Scope* scope,

}

-bool Variable::is_global() const {

+bool Variable::IsGlobalObjectProperty() const {

// Temporaries are never global, they must always be allocated in the

// activation frame.

- return mode_ != TEMPORARY && scope_ != NULL && scope_->is_global_scope();

+ return mode_ != TEMPORARY && mode_ != LET && mode_ != CONST_HARMONY

+ && scope_ != NULL && scope_->is_global_scope();

}