Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10872072: foo (1).user.js, not foo.user (1).js. (Closed)

Created:
8 years, 4 months ago by Aaron Boodman
Modified:
8 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

foo (1).user.js, not foo.user (1).js. BUG=136795 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153409

Patch Set 1 #

Patch Set 2 : grump #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M base/file_path.cc View 1 2 chunks +23 lines, -20 lines 0 comments Download
M base/file_path_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Aaron Boodman
8 years, 4 months ago (2012-08-24 23:38:52 UTC) #1
Mark Mentovai
LGTM
8 years, 4 months ago (2012-08-25 14:13:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/10872072/2001
8 years, 4 months ago (2012-08-26 01:23:41 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-08-26 12:11:11 UTC) #4 
Change committed as 153409

Powered by Google App Engine
This is Rietveld 408576698