Issue 10872067: No more extension install infobars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10872067: No more extension install infobars. (Closed)

Created:
8 years, 4 months ago by Yoyo Zhou

Modified:
8 years, 3 months ago

Reviewers:
sail

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, Finnur

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

No more extension install infobars (on Mac). BUG=109940 TEST=On mac, install https://chrome.google.com/webstore/detail/dmgcpfplbobdchnijhbmogkbibagiiam and see a bubble pointing to the wrench menu instead of an infobar. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153602

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -64 lines)			Patch
	M	chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm	View		2 chunks	+14 lines, -58 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm	View		3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/10872067/1

8 years, 3 months ago (2012-08-27 20:26:01 UTC) #5

commit-bot: I haz the power

8 years, 3 months ago (2012-08-28 00:45:44 UTC) #6

Try job failure for 10872067-1 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Expand Messages | Collapse Messages