Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2371)

Unified Diff: android_webview/tools/webview_licenses.py

Issue 10872061: [Android] Update Android WebView license checking tool. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/buildbot_functions.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/tools/webview_licenses.py
diff --git a/android_webview/tools/webview_licenses.py b/android_webview/tools/webview_licenses.py
index ec2e44d9e648288c3612c8b59c9cffcffb413a4c..aa72d9b77885035deab40036160d2dfcf616cc8f 100755
--- a/android_webview/tools/webview_licenses.py
+++ b/android_webview/tools/webview_licenses.py
@@ -91,6 +91,7 @@ def _CheckLicenseHeaders(directory_list, whitelisted_files):
'--exclude-dir', 'third_party',
'--exclude-dir', 'out',
'--exclude-dir', '.git',
+ '--exclude-dir', '.svn',
regex,
'.']
p = subprocess.Popen(args=args, cwd=REPOSITORY_ROOT, stdout=subprocess.PIPE)
@@ -101,12 +102,20 @@ def _CheckLicenseHeaders(directory_list, whitelisted_files):
directory_list.append('android_webview/tools/')
# This is a build intermediate directory.
directory_list.append('chrome/app/theme/google_chrome/')
+ # This is tests directory, doesn't exist in the snapshot
+ directory_list.append('content/test/data/')
+ # This is a test output directory.
+ directory_list.append('data/dom_perf/')
# This is a test output directory.
directory_list.append('data/page_cycler/')
# 'Copyright' appears in strings.
directory_list.append('chrome/app/resources/')
# This is a Chrome on Linux reference build, doesn't exist in the snapshot
directory_list.append('chrome/tools/test/reference_build/chrome_linux/')
+ # Remoting internal tools, doesn't exist in the snapshot
+ directory_list.append('remoting/appengine/')
+ # Histogram tools, doesn't exist in the snapshot
+ directory_list.append('tools/histograms/')
# Exclude files under listed directories and some known offenders.
offending_files = []
@@ -162,6 +171,8 @@ def _FindThirdPartyDirs():
# Apache 2.0 license. See
# https://code.google.com/p/chromium/issues/detail?id=140478.
os.path.join('third_party', 'bidichecker'),
+ # Isn't checked out on clients
+ os.path.join('third_party', 'gles2_conform'),
]
return licenses.FindThirdPartyDirs(prune_paths)
« no previous file with comments | « no previous file | build/android/buildbot_functions.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698