lib/compiler/implementation/ssa/codegen.dart - Issue 10872059: Static and top-level methods can be compile time constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10872059: Static and top-level methods can be compile time constants. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/compiler/implementation/compile_time_constants.dart ('K') | « lib/compiler/implementation/compile_time_constants.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | lib/compiler/implementation/ssa/nodes.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/ssa/codegen.dart

===================================================================

--- lib/compiler/implementation/ssa/codegen.dart (revision 11378)

+++ lib/compiler/implementation/ssa/codegen.dart (working copy)

@@ -1683,8 +1683,15 @@

CodeBuffer buffer = new CodeBuffer();

handler.writeConstant(buffer, constant);

push(new js.LiteralString(buffer.toString()));

+ } else if (constant.isFunction()) {

+ FunctionConstant function = constant;

+ world.registerStaticUse(function.element);

+ push(new js.VariableUse(

+ compiler.namer.isolateAccess(function.element)));

} else {

- compiler.internalError("Forgot constant $constant");

+ compiler.internalError(

+ "The compiler does not know how generate code for "

+ "constant $constant");

}

} else {

js.VariableUse currentIsolateUse =