Provide iOS implementation of screen.h.

Provide iOS implementation of screen.h.


BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154442

[blundell, 2012-08-23 16:35:00]

PTAL, thanks.

[stuartmorgan, 2012-08-23 19:20:18]

LGTM with nits
+thakis for owners

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/gfx/screen_ios.mm
File ui/gfx/screen_ios.mm (right):

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/gfx/screen_ios.mm#n...
ui/gfx/screen_ios.mm:1: // Copyright (c) 2011 The Chromium Authors. All rights
reserved.
2012

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/gfx/screen_ios.mm#n...
ui/gfx/screen_ios.mm:23: // Looks like UIScreens seems to lie on the simulator
at times.
// UIScreen does not reliably return correct results on the simulator.

[Nico, 2012-08-23 19:31:27]

lgtm except for the gyp file.

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/gfx/screen_ios.mm
File ui/gfx/screen_ios.mm (right):

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/gfx/screen_ios.mm#n...
ui/gfx/screen_ios.mm:15: UIScreen* mainScreen = [UIScreen mainScreen];
optional nit: since mainScreen means something different on ios and osx, maybe
it's less confusing to the reader if you say [[UIScreen screens]
objectAtIndex:0].

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/ui.gyp
File ui/ui.gyp (right):

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/ui.gyp#newcode54
ui/ui.gyp:54: 'gfx/screen_ios.mm',
Should all the other screen_ files be here too, so that they are in one place?
(especially the .h file)

[stuartmorgan, 2012-08-24 04:36:51]

On 2012/08/23 19:31:27, Nico wrote:
> Should all the other screen_ files be here too, so that they are in one place?
> (especially the .h file)

Agreed

[blundell, 2012-08-30 09:18:51]

Thanks for the reviews.

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/gfx/screen_ios.mm
File ui/gfx/screen_ios.mm (right):

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/gfx/screen_ios.mm#n...
ui/gfx/screen_ios.mm:1: // Copyright (c) 2011 The Chromium Authors. All rights
reserved.
On 2012/08/23 19:20:19, stuartmorgan wrote:
> 2012

Done.

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/gfx/screen_ios.mm#n...
ui/gfx/screen_ios.mm:15: UIScreen* mainScreen = [UIScreen mainScreen];
On 2012/08/23 19:31:28, Nico wrote:
> optional nit: since mainScreen means something different on ios and osx, maybe
> it's less confusing to the reader if you say [[UIScreen screens]
> objectAtIndex:0].

Done.

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/gfx/screen_ios.mm#n...
ui/gfx/screen_ios.mm:23: // Looks like UIScreens seems to lie on the simulator
at times.
On 2012/08/23 19:20:19, stuartmorgan wrote:
> // UIScreen does not reliably return correct results on the simulator.

Done.

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/ui.gyp
File ui/ui.gyp (right):

https://chromiumcodereview.appspot.com/10872042/diff/1/ui/ui.gyp#newcode54
ui/ui.gyp:54: 'gfx/screen_ios.mm',
On 2012/08/23 19:31:28, Nico wrote:
> Should all the other screen_ files be here too, so that they are in one place?
> (especially the .h file)

Done.

[commit-bot: I haz the power, 2012-08-30 09:20:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/10872042/6001

[commit-bot: I haz the power, 2012-08-30 11:59:54]

Try job failure for 10872042-6001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, steps "interactive_ui_tests, browser_tests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-31 09:21:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/10872042/6001

[commit-bot: I haz the power, 2012-08-31 13:47:26]

Try job failure for 10872042-6001 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-31 13:50:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/10872042/6001

[commit-bot: I haz the power, 2012-08-31 16:31:31]

Change committed as 154442