Issue 10872037: Test case for conflicting global declarations across multiple scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10872037: Test case for conflicting global declarations across multiple scripts. (Closed)

Created:
8 years, 4 months ago by rossberg

Modified:
8 years, 4 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Test case for conflicting global declarations across multiple scripts. R=ulan@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12374

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments; reordered some tests. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+220 lines, -3 lines)			Patch
	M	test/cctest/test-decls.cc	View	1	4 chunks	+220 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ulan

8 years, 4 months ago (2012-08-23 16:10:17 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10872037/diff/1/test/cctest/test-decls.cc
File test/cctest/test-decls.cc (right):

https://chromiumcodereview.appspot.com/10872037/diff/1/test/cctest/test-decls...
test/cctest/test-decls.cc:710: HEAP->CollectGarbage(v8::internal::NEW_SPACE);
Don't forget to remove it as we discussed offline.

Expand Messages | Collapse Messages