Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: chrome/browser/chrome_plugin_browsertest.cc

Issue 10872034: Changing PluginPrefs to use PluginFinder's async interface. (Closed) Base URL: http://git.chromium.org/chromium/src.git@test_async
Patch Set: Fixed bug in chromeos loading the plugins page Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_plugin_browsertest.cc
diff --git a/chrome/browser/chrome_plugin_browsertest.cc b/chrome/browser/chrome_plugin_browsertest.cc
index a26d3eb37b23bb08aaec5a090df06c52d01e62e0..7763da7c54160e25fa09a55c99337d67bccaf0a8 100644
--- a/chrome/browser/chrome_plugin_browsertest.cc
+++ b/chrome/browser/chrome_plugin_browsertest.cc
@@ -84,7 +84,8 @@ class ChromePluginTest : public InProcessBrowserTest {
PluginPrefs* plugin_prefs = PluginPrefs::GetForProfile(profile);
scoped_refptr<content::MessageLoopRunner> runner =
new content::MessageLoopRunner;
- plugin_prefs->EnablePlugin(enable, flash_path, runner->QuitClosure());
+ plugin_prefs->EnablePlugin(enable, flash_path,
+ base::Bind(&AssertPluginEnabled, runner));
runner->Run();
}
@@ -132,6 +133,13 @@ class ChromePluginTest : public InProcessBrowserTest {
}
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, quit_task);
}
+
+ static void AssertPluginEnabled(
+ scoped_refptr<content::MessageLoopRunner> runner,
+ bool did_enable) {
+ ASSERT_TRUE(did_enable);
+ runner->Quit();
+ }
};
// Tests a bunch of basic scenarios with Flash.

Powered by Google App Engine
This is Rietveld 408576698