Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 10872032: Revert 152946 - Replace HistoryQuickProvider protobuf-based caching with an SQLite-based database. (Closed)

Created:
8 years, 4 months ago by ricow1
Modified:
8 years, 4 months ago
Reviewers:
mrossetti
CC:
chromium-reviews, pam+watch_chromium.org, timurrrr+watch_chromium.org, brettw-cc_chromium.org, James Su, glider+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Revert 152946 - Replace HistoryQuickProvider protobuf-based caching with an SQLite-based database. The protobuf-based cache was only being read at startup and written at shutdown. (Except that when the cache could not be read at startup the cache would immediately be saved upon private data reconstruction from the History database.) With the new implementation using an SQLite database for the HQP cache the private data will be restored from the cache database at startup and continually updated during normal operation. There is no need to flush or write the cache at shutdown as it is constantly kept up-to-date. Detailed comments about the changes made in this CL can be found in the document shared separately. Previous reviewers: sky, pkasting, shess. BUG=95686, 95876, 131668 TEST=New tests added, old tests updated, all tests pass. To manually verify changes: NOTE: For tests using chrome://omnibox be sure to check the "Show results per provider" and then look at the results for the HistoryQuickProvider. 1) New visits: Type an URL never visited before. Bring up new tab. Start typing the URL or parts of the page title or both and verify that the page is offered as a suggestion. 2) New visits: Type an URL never visited before. Do search using chrome://omnibox. New visit should show. 3) Delete visit: Visit some pages and verify they have been recorded. Bring up history and delete one of the visits. Check via chrome://omnibox that it was deleted. 4) Clear history: Visit some pages. Clear the visit history. Check via chrome://omnibox that none of the visits are still returned by the HQP. 5) Updated site: Create a local page and visit it. Search using chrome://omnibox by page title and verify it can be found. Change the page title dramatically and revisit the page. Verify via chrome://oomnibox that the page can be found by words from the new title. Previously reviewed as: http://codereview.chromium.org/10477018/. 10477018 was reverted due to memory leaks detected by build bots. Review URL: https://chromiumcodereview.appspot.com/10837244 TBR=mrossetti@chromium.org This is causing performance regressions across a range of perf bots. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2186 lines, -3771 lines) Patch
M chrome/browser/autocomplete/history_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/history_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 4 chunks +196 lines, -16 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_model.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_model_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/diagnostics/sqlite_diagnostics.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/diagnostics/sqlite_diagnostics.cc View 3 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/history/history.h View 8 chunks +8 lines, -23 lines 0 comments Download
M chrome/browser/history/history.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 9 chunks +114 lines, -182 lines 0 comments Download
M chrome/browser/history/history_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_database.h View 1 chunk +1 line, -4 lines 0 comments Download
D chrome/browser/history/in_memory_url_cache_database.h View 1 chunk +0 lines, -218 lines 0 comments Download
D chrome/browser/history/in_memory_url_cache_database.cc View 1 chunk +0 lines, -692 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.h View 7 chunks +127 lines, -134 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 5 chunks +156 lines, -204 lines 0 comments Download
D chrome/browser/history/in_memory_url_index_base_unittest.h View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/history/in_memory_url_index_base_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
M chrome/browser/history/in_memory_url_index_types.h View 2 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/history/in_memory_url_index_types_unittest.cc View 4 chunks +19 lines, -22 lines 0 comments Download
M chrome/browser/history/in_memory_url_index_unittest.cc View 9 chunks +627 lines, -647 lines 0 comments Download
M chrome/browser/history/scored_history_match.h View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/history/scored_history_match_unittest.cc View 4 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/history/top_sites_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/url_index_private_data.h View 6 chunks +136 lines, -186 lines 0 comments Download
M chrome/browser/history/url_index_private_data.cc View 10 chunks +715 lines, -655 lines 0 comments Download
D chrome/browser/history/url_index_private_data_unittest.cc View 1 chunk +0 lines, -283 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_master.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
MM chrome/common/chrome_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +0 lines, -3 lines 0 comments Download
MM chrome/common/chrome_notification_types.h View 1 chunk +0 lines, -7 lines 0 comments Download
MM chrome/test/base/testing_profile.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +5 lines, -10 lines 0 comments Download
D chrome/test/data/History/history_quick_provider_ordering_test.db.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/test/data/History/history_quick_provider_test.db.txt View 1 chunk +0 lines, -62 lines 0 comments Download
MM chrome/test/data/History/url_history_provider_test.db.txt View 1 chunk +28 lines, -28 lines 0 comments Download
MM chrome/test/data/History/url_history_provider_test_limited.db.txt View 1 chunk +1 line, -1 line 0 comments Download
MM sql/diagnostic_error_delegate.h View 2 chunks +3 lines, -5 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ricow1
8 years, 4 months ago (2012-08-23 09:09:33 UTC) #1
mrossetti
8 years, 4 months ago (2012-08-23 16:05:54 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698