Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 10872025: [sync] Apply sync config changes only after sync backend is initialized (Closed)

Created:
8 years, 4 months ago by Raghu Simha
Modified:
8 years, 4 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Base URL:
http://git.chromium.org/chromium/src.git@12-08-22-SeparateDirSwitch
Visibility:
Public.

Description

[sync] Apply sync config changes only after sync backend is initialized During chrome startup on Win 8, if CredentialCacheService detects sync config changes in the alternate profile, we try to apply them immediately. Instead, we must try to apply config changes only after the sync backend is initialized, and preferably, after local sync configuration is done. This patch does the following: 1) Modify the constraints in MayReconfigureSync to include the fact that the sync backend has been initialized. 2) In case of sync auto-start, we try to consume config changes, if any, from the alternate profile once local configuration is done. 3) Update ScheduleNextReadFromAlternateCredentialCache to take a delay parameter, so that we can schedule a read of the alternate cache immediately or in the future. BUG=144302 TEST=Sign in on desktop; launch metro (so it signs in); close desktop; reconfigure metro; restart desktop; make sure config changes from metro are immediately applied on desktop. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153123

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR Feedback + rebase on ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M chrome/browser/sync/credential_cache_service_win.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/credential_cache_service_win.cc View 1 10 chunks +29 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Raghu Simha
Nicolas, please review. Thanks.
8 years, 4 months ago (2012-08-23 00:03:37 UTC) #1
Nicolas Zea
http://codereview.chromium.org/10872025/diff/1/chrome/browser/sync/credential_cache_service_win.cc File chrome/browser/sync/credential_cache_service_win.cc (right): http://codereview.chromium.org/10872025/diff/1/chrome/browser/sync/credential_cache_service_win.cc#newcode852 chrome/browser/sync/credential_cache_service_win.cc:852: service->sync_initialized(); would should push changes be more appropriate here?
8 years, 4 months ago (2012-08-23 23:00:48 UTC) #2
Raghu Simha
PTAL. http://codereview.chromium.org/10872025/diff/1/chrome/browser/sync/credential_cache_service_win.cc File chrome/browser/sync/credential_cache_service_win.cc (right): http://codereview.chromium.org/10872025/diff/1/chrome/browser/sync/credential_cache_service_win.cc#newcode852 chrome/browser/sync/credential_cache_service_win.cc:852: service->sync_initialized(); On 2012/08/23 23:00:48, nzea wrote: > would ...
8 years, 4 months ago (2012-08-23 23:15:20 UTC) #3
Nicolas Zea
8 years, 4 months ago (2012-08-23 23:20:18 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698