Chromium Code Reviews
Description[sync] Apply sync config changes only after sync backend is initialized
During chrome startup on Win 8, if CredentialCacheService detects sync config changes in the alternate profile, we try to apply them immediately. Instead, we must try to apply config changes only after the sync backend is initialized, and preferably, after local sync configuration is done.
This patch does the following:
1) Modify the constraints in MayReconfigureSync to include the fact that the sync backend has been initialized.
2) In case of sync auto-start, we try to consume config changes, if any, from the alternate profile once local configuration is done.
3) Update ScheduleNextReadFromAlternateCredentialCache to take a delay parameter, so that we can schedule a read of the alternate cache immediately or in the future.
BUG=144302
TEST=Sign in on desktop; launch metro (so it signs in); close desktop; reconfigure metro; restart desktop; make sure config changes from metro are immediately applied on desktop.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153123
Patch Set 1 #
Total comments: 2
Patch Set 2 : CR Feedback + rebase on ToT #
Messages
Total messages: 4 (0 generated)
|
||||||||||||||||||||||||||||