Issue 10872010: Reland regexp global optimizations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10872010: Reland regexp global optimizations. (Closed)

Created:
8 years, 4 months ago by Yang

Modified:
8 years, 3 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland regexp global optimizations. BUG= Committed: https://code.google.com/p/v8/source/detail?r=12396

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+594 lines, -785 lines)			Patch
M	src/arm/code-stubs-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/assembler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/jsregexp.h	View		5 chunks	+51 lines, -63 lines	0 comments	Download
M	src/jsregexp.cc	View		9 chunks	+227 lines, -72 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1	16 chunks	+270 lines, -641 lines	0 comments	Download
M	src/unicode.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/unicode-inl.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-regexp.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-strings.cc	View	1	2 chunks	+18 lines, -1 line	0 comments	Download
M	test/mjsunit/regexp-global.js	View	1	1 chunk	+13 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Yang

The second patch set fixes the bug that should be causing the crashes on Canary. ...

8 years, 4 months ago (2012-08-22 13:16:08 UTC) #1

ulan

8 years, 3 months ago (2012-08-28 07:19:09 UTC) #2

The diff between patch set 1 and 2 LGTM, rubber-stamping the rest.