rlz: Add a binary that prints the machine id

rlz: Add a binary that prints the machine id

Partners apparently need this for something. There's a Windows
version of this too already, but I couldn't find the source for
that.

BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152880

[Nico, 2012-08-22 05:15:45]

https://chromiumcodereview.appspot.com/10872005/diff/1005/rlz/examples/rlz_id.cc
File rlz/examples/rlz_id.cc (right):

https://chromiumcodereview.appspot.com/10872005/diff/1005/rlz/examples/rlz_id...
rlz/examples/rlz_id.cc:13: }
I'm not sure if "examples" is a great name for this folder.

[Nico, 2012-08-22 20:43:18]

Ping?

On Tue, Aug 21, 2012 at 10:15 PM,  <thakis@chromium.org> wrote:
> Reviewers: Roger Tawa,
>
>
>
https://chromiumcodereview.appspot.com/10872005/diff/1005/rlz/examples/rlz_id.cc
> File rlz/examples/rlz_id.cc (right):
>
>
https://chromiumcodereview.appspot.com/10872005/diff/1005/rlz/examples/rlz_id...
> rlz/examples/rlz_id.cc:13: }
> I'm not sure if "examples" is a great name for this folder.
>
> Description:
> rlz: Add a binary that prints the machine id
>
> Partners apparently need this for something. There's a Windows
> version of this too already, but I couldn't find the source for
> that.
>
> BUG=none
>
>
> Please review this at https://chromiumcodereview.appspot.com/10872005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   A + rlz/examples/rlz_id.cc
>   M rlz/rlz.gyp
>
>
> Index: rlz/examples/rlz_id.cc
> diff --git a/chrome/browser/android/tab_android.cc b/rlz/examples/rlz_id.cc
> similarity index 51%
> copy from chrome/browser/android/tab_android.cc
> copy to rlz/examples/rlz_id.cc
> index
>
1b9345a82a6140472c37d9694a3b5281c0df8573..ce01f1831f8e55f4b00bfff1e4b9e829b62648f8
> 100644
> --- a/chrome/browser/android/tab_android.cc
> +++ b/rlz/examples/rlz_id.cc
> @@ -2,10 +2,12 @@
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> -#include "chrome/browser/android/tab_android.h"
> +#include "rlz/lib/machine_id.h"
>
> -TabAndroid::TabAndroid() : tab_id_(-1) {
> -}
> +int main() {
> +  std::string machine_id;
> +  if (!rlz_lib::GetMachineId(&machine_id))
> +    return 1;
>
> -TabAndroid::~TabAndroid() {
> +  printf("%s\n", machine_id.c_str());
>  }
> Index: rlz/rlz.gyp
> diff --git a/rlz/rlz.gyp b/rlz/rlz.gyp
> index
>
5b0db4b798d1cca3979a4c1b2c61331440935403..528413411c24246efc9da77b5c6740e0a52f8591
> 100644
> --- a/rlz/rlz.gyp
> +++ b/rlz/rlz.gyp
> @@ -27,7 +27,6 @@
>      {
>        'target_name': 'rlz_lib',
>        'type': 'static_library',
> -      'include_dirs': [],
>        'dependencies': [
>          '../base/base.gyp:base',
>
>
'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
> @@ -99,7 +98,6 @@
>      {
>        'target_name': 'rlz_unittests',
>        'type': 'executable',
> -      'include_dirs': [],
>        'dependencies': [
>          ':rlz_lib',
>          '../base/base.gyp:base',
> @@ -128,6 +126,16 @@
>          }]
>        ],
>      },
> +    {
> +      'target_name': 'rlz_id',
> +      'type': 'executable',
> +      'dependencies': [
> +        ':rlz_lib',
> +      ],
> +      'sources': [
> +        'examples/rlz_id.cc',
> +      ],
> +    },
>    ],
>    'conditions': [
>      ['OS=="win"', {
> @@ -135,7 +143,6 @@
>          {
>            'target_name': 'rlz',
>            'type': 'shared_library',
> -          'include_dirs': [],
>            'sources': [
>              'win/dll/dll_main.cc',
>              'win/dll/exports.cc',
>
>

[Roger Tawa OOO till Jul 10th, 2012-08-22 21:20:12]

lgtm

Sorry for delay.

[commit-bot: I haz the power, 2012-08-22 21:23:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10872005/1005

[commit-bot: I haz the power, 2012-08-22 23:58:08]

Change committed as 152880