Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Issue 10871091: Set gamma correction settings to match platform. (Closed)

Created:
8 years, 3 months ago by bungeman-chromium
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Set gamma correction settings to match platform. BUG=144809, 145317, 141425

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M skia/skia.gyp View 1 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
bungeman-chromium
See http://code.google.com/p/chromium/issues/detail?id=145317 This change states what we're currently doing on Windows and Mac, and makes ...
8 years, 3 months ago (2012-08-28 22:06:33 UTC) #1
kerz_google
lgtm
8 years, 3 months ago (2012-08-28 22:13:16 UTC) #2
Nico
Thanks! Can you add a BUG= line to your CL description? http://codereview.chromium.org/10871091/diff/1/skia/skia.gyp File skia/skia.gyp (right): ...
8 years, 3 months ago (2012-08-28 22:28:20 UTC) #3
Daniel Erat
Drive-by comment: If this is the cause of http://code.google.com/p/chromium/issues/detail?id=141425 and http://code.google.com/p/chromium/issues/detail?id=144809, please add a: BUG=141425,141425 ...
8 years, 3 months ago (2012-08-29 01:23:03 UTC) #4
Daniel Erat
On 2012/08/29 01:23:03, Daniel Erat wrote: > Drive-by comment: If this is the cause of ...
8 years, 3 months ago (2012-08-29 01:23:28 UTC) #5
Nico
ping
8 years, 3 months ago (2012-08-29 18:21:13 UTC) #6
bungeman-skia
http://codereview.chromium.org/10871091/diff/1/skia/skia.gyp File skia/skia.gyp (right): http://codereview.chromium.org/10871091/diff/1/skia/skia.gyp#newcode253 skia/skia.gyp:253: [ 'OS == "android" or OS == "linux"', { ...
8 years, 3 months ago (2012-08-29 19:31:16 UTC) #7
Nico
On 2012/08/29 19:31:16, bungeman1 wrote: > http://codereview.chromium.org/10871091/diff/1/skia/skia.gyp > File skia/skia.gyp (right): > > http://codereview.chromium.org/10871091/diff/1/skia/skia.gyp#newcode253 > ...
8 years, 3 months ago (2012-08-29 19:34:02 UTC) #8
bungeman-skia
> Cool. Can you add a BUG= line to the CL description? Then this is ...
8 years, 3 months ago (2012-08-29 19:47:42 UTC) #9
Nico
lgtm
8 years, 3 months ago (2012-08-29 20:01:47 UTC) #10
bungeman-skia
8 years, 3 months ago (2012-08-29 21:34:50 UTC) #11
Committed revision 153958.

Powered by Google App Engine
This is Rietveld 408576698