Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 10871088: Revert "Implementing polyfills for insertAdjacent* to get them working on FF." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Merging.wq Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « lib/html/dart2js/html_dart2js.dart ('k') | lib/html/doc/interface/Element.dartdoc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/dartium/html_dartium.dart
diff --git a/lib/html/dartium/html_dartium.dart b/lib/html/dartium/html_dartium.dart
index e7491f922ff1552c52bc7d3f08adc0774a4d01d8..424f0d25c6c21899ce268b66c12fedd39c5cfe5b 100644
--- a/lib/html/dartium/html_dartium.dart
+++ b/lib/html/dartium/html_dartium.dart
@@ -47,7 +47,7 @@ class _Null {
const _Null();
}
-const _null = const _Null();
+final _null = const _Null();
int _getNewIsolateId() => _Utils._getNewIsolateId();
@@ -5918,14 +5918,6 @@ class _DocumentFragmentImpl extends _NodeImpl implements DocumentFragment {
this._insertAdjacentNode(where, new DocumentFragment.html(text));
}
- void addText(String text) {
- this.insertAdjacentText('beforeend', text);
- }
-
- void addHTML(String text) {
- this.insertAdjacentHTML('beforeend', text);
- }
-
Future<ElementRect> get rect() {
return _createMeasurementFuture(() => const EmptyElementRect(),
new Completer<ElementRect>());
@@ -7112,14 +7104,14 @@ class _ElementRectImpl implements ElementRect {
// TODO(jacobr): should we move these outside of ElementRect to avoid the
// overhead of computing them every time even though they are rarely used.
- final _ClientRectImpl _boundingClientRect;
+ final _ClientRectImpl _boundingClientRect;
final _ClientRectListImpl _clientRects;
_ElementRectImpl(_ElementImpl element) :
client = new _SimpleClientRect(element.$dom_clientLeft,
element.$dom_clientTop,
- element.$dom_clientWidth,
- element.$dom_clientHeight),
+ element.$dom_clientWidth,
+ element.$dom_clientHeight),
offset = new _SimpleClientRect(element.$dom_offsetLeft,
element.$dom_offsetTop,
element.$dom_offsetWidth,
@@ -7208,14 +7200,6 @@ class _ElementImpl extends _NodeImpl implements Element {
new Completer<CSSStyleDeclaration>());
}
- void addText(String text) {
- this.insertAdjacentText('beforeend', text);
- }
-
- void addHTML(String text) {
- this.insertAdjacentHTML('beforeend', text);
- }
-
// Hooks to support custom WebComponents.
var xtag;
@@ -7228,7 +7212,6 @@ class _ElementImpl extends _NodeImpl implements Element {
}
-
_ElementEventsImpl get on() =>
new _ElementEventsImpl(this);
@@ -7337,9 +7320,9 @@ class _ElementImpl extends _NodeImpl implements Element {
// Temporary dispatch hook to support WebComponents.
Function dynamicUnknownElementDispatcher;
-const _START_TAG_REGEXP = const RegExp('<(\\w+)');
+final _START_TAG_REGEXP = const RegExp('<(\\w+)');
class _ElementFactoryProvider {
- static const _CUSTOM_PARENT_TAG_MAP = const {
+ static final _CUSTOM_PARENT_TAG_MAP = const {
'body' : 'html',
'head' : 'html',
'caption' : 'table',
@@ -13025,7 +13008,7 @@ class _MutationObserverImpl extends NativeFieldWrapperClass1 implements Mutation
}
// TODO: Change to a set when const Sets are available.
- static const _boolKeys =
+ static final _boolKeys =
const {'childList': true,
'attributes': true,
'characterData': true,
@@ -26678,17 +26661,6 @@ interface Element extends Node, NodeSelector default _ElementFactoryProvider {
void set dataAttributes(Map<String, String> value);
/**
- * Adds the specified text as a text node after the last child of this.
- */
- void addText(String text);
-
- /**
- * Parses the specified text as HTML and adds the resulting node after the
- * last child of this.
- */
- void addHTML(String html);
-
- /**
* @domName getClientRects, getBoundingClientRect, clientHeight, clientWidth,
* clientTop, clientLeft, offsetHeight, offsetWidth, offsetTop, offsetLeft,
* scrollHeight, scrollWidth, scrollTop, scrollLeft
« no previous file with comments | « lib/html/dart2js/html_dart2js.dart ('k') | lib/html/doc/interface/Element.dartdoc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698