First part of remembering platform app window geometry.

chrome/browser/extensions/api/app_window/app_window_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/app_window/app_window_api.h"
 
 #include "base/time.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/shell_window_registry.h"
 #include "chrome/browser/extensions/window_controller.h"
@@ skipping 40 matching lines @@
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   GURL url = GetExtension()->GetResourceURL(params->url);
 
   // TODO(jeremya): figure out a way to pass the opening WebContents through to
   // ShellWindow::Create so we can set the opener at create time rather than
   // with a hack in AppWindowCustomBindings::GetView().
   ShellWindow::CreateParams create_params;
   app_window::CreateWindowOptions* options = params->options.get();
   if (options) {
-    if (options->width.get())
-      create_params.bounds.set_width(*options->width.get());
-    if (options->height.get())
-      create_params.bounds.set_height(*options->height.get());
-    if (options->left.get())
-      create_params.bounds.set_x(*options->left.get());
-    if (options->top.get())
-      create_params.bounds.set_y(*options->top.get());
+    if (options->id.get())
+      // TODO(mek): use URL if no id specified?
+      create_params.window_key = *options->id;

[asargent_no_longer_on_chrome, 2012/08/28 18:49:41]

nit: can you enforce that the id is some reasonable length here? (maybe 256 or
less?)

BTW, we will eventually have "automagic" support for declaring this in the .idl
file and having it be enforced by the bindings: crbug.com/131617

[Marijn Kruisselbrink, 2012/08/28 22:14:58]

Done.

+
+    if (options->default_width.get())
+      create_params.bounds.set_width(*options->default_width.get());
+    if (options->default_height.get())
+      create_params.bounds.set_height(*options->default_height.get());
+    if (options->default_left.get())
+      create_params.bounds.set_x(*options->default_left.get());
+    if (options->default_top.get())
+      create_params.bounds.set_y(*options->default_top.get());
+
+
+    if (options->width.get() || options->height.get()) {
+      if (options->width.get())
+        create_params.bounds.set_width(*options->width.get());
+      if (options->height.get())
+        create_params.bounds.set_height(*options->height.get());
+      create_params.restoreSize = false;
+    }
+
+    if (options->left.get() || options->top.get()) {
+      if (options->left.get())
+        create_params.bounds.set_x(*options->left.get());
+      if (options->top.get())
+        create_params.bounds.set_y(*options->top.get());
+      create_params.restorePosition = false;
+    }
 
     if (options->frame.get()) {
       create_params.frame = *options->frame == kNoneFrameOption ?
           ShellWindow::CreateParams::FRAME_NONE :
           ShellWindow::CreateParams::FRAME_CHROME;
     }
 
     gfx::Size& minimum_size = create_params.minimum_size;
     if (options->min_width.get())
       minimum_size.set_width(*options->min_width);
@@ skipping 48 matching lines @@
   window->GetBaseWindow()->Minimize();
   return true;
 }
 
 bool AppWindowRestoreFunction::RunWithWindow(ShellWindow* window) {
   window->GetBaseWindow()->Restore();
   return true;
 }
 
 }  // namespace extensions