chrome/browser/ui/constrained_window_tab_helper.cc - Issue 10871082: Constrained Windows Cocoa: Part 4 Refactor ConstrainedWindowSupport

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/constrained_window_tab_helper.cc

Issue 10871082: Constrained Windows Cocoa: Part 4 Refactor ConstrainedWindowSupport (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review comments Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/constrained_window_tab_helper.cc

diff --git a/chrome/browser/ui/constrained_window_tab_helper.cc b/chrome/browser/ui/constrained_window_tab_helper.cc

index 3d8d103e002ae3b4024d11b053ad456fe086380c..ff03e25f31dc5fbbaed26e4e65d71fbb91e49474 100644

--- a/chrome/browser/ui/constrained_window_tab_helper.cc

+++ b/chrome/browser/ui/constrained_window_tab_helper.cc

@@ -32,7 +32,7 @@ void ConstrainedWindowTabHelper::AddConstrainedDialog(

ConstrainedWindow* window) {

child_windows_.push_back(window);

- if (child_windows_.size() == 1) {

+ if (child_windows_.size() == 1 && window->CanShowConstrainedWindow()) {

window->ShowConstrainedWindow();

BlockTabContent(true);

}

« no previous file with comments | « chrome/browser/ui/constrained_window.cc ('k') | chrome/browser/ui/gtk/browser_window_gtk.h » ('j') | no next file with comments »