Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2845)

Unified Diff: chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm

Issue 10871082: Constrained Windows Cocoa: Part 4 Refactor ConstrainedWindowSupport (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm b/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm
index b32ac75d0ad2f08bb6a137dbc5b86aad62402986..65e819feb11d104ff38801db79868ecd979ae2d3 100644
--- a/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm
@@ -64,23 +64,13 @@
[[self window] makeKeyAndOrderFront:self];
}
-- (void)attachConstrainedWindow:(ConstrainedWindowMac*)window {
+- (GTMWindowSheetController*)sheetController {
if (!sheetController_.get()) {
sheetController_.reset([[GTMWindowSheetController alloc]
initWithWindow:[self window]
delegate:self]);
}
-
- NSView* tabContentsView =
- [window->owner()->web_contents()->GetNativeView() superview];
- window->delegate()->RunSheet(sheetController_, tabContentsView);
-}
-
-- (void)removeConstrainedWindow:(ConstrainedWindowMac*)window {
-}
-
-- (BOOL)canAttachConstrainedWindow {
- return YES;
+ return sheetController_;
}
- (void)executeCommand:(int)command {
« no previous file with comments | « chrome/browser/ui/cocoa/constrained_window_mac.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698