Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: runtime/vm/intrinsifier_ia32.cc

Issue 10871052: Disable intrinisification of GrowableArray add until apidoc crash is fixed. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/intrinsifier_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // The intrinsic code below is executed before a method has built its frame. 5 // The intrinsic code below is executed before a method has built its frame.
6 // The return address is on the stack and the arguments below it. 6 // The return address is on the stack and the arguments below it.
7 // Registers EDX (arguments descriptor) and ECX (function) must be preserved. 7 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
8 // Each intrinsification method returns true if the corresponding 8 // Each intrinsification method returns true if the corresponding
9 // Dart method was intrinsified. 9 // Dart method was intrinsified.
10 10
(...skipping 408 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 EBX); 419 EBX);
420 __ ret(); 420 __ ret();
421 return true; 421 return true;
422 } 422 }
423 423
424 424
425 // Add an element to growable array if it doesn't need to grow, otherwise 425 // Add an element to growable array if it doesn't need to grow, otherwise
426 // call into regular code. 426 // call into regular code.
427 // On stack: growable array (+2), value (+1), return-address (+0). 427 // On stack: growable array (+2), value (+1), return-address (+0).
428 bool Intrinsifier::GrowableArray_add(Assembler* assembler) { 428 bool Intrinsifier::GrowableArray_add(Assembler* assembler) {
429 // TODO(srdjan): Enable once crash in apidoc.dart is fixed.
430 return false;
429 // In checked mode we need to check the incoming argument. 431 // In checked mode we need to check the incoming argument.
430 if (FLAG_enable_type_checks) return false; 432 if (FLAG_enable_type_checks) return false;
431 Label fall_through; 433 Label fall_through;
432 __ movl(EAX, Address(ESP, + 2 * kWordSize)); // Array. 434 __ movl(EAX, Address(ESP, + 2 * kWordSize)); // Array.
433 __ movl(EBX, FieldAddress(EAX, GrowableObjectArray::length_offset())); 435 __ movl(EBX, FieldAddress(EAX, GrowableObjectArray::length_offset()));
434 // EBX: length. 436 // EBX: length.
435 __ movl(EDI, FieldAddress(EAX, GrowableObjectArray::data_offset())); 437 __ movl(EDI, FieldAddress(EAX, GrowableObjectArray::data_offset()));
436 // EDI: data. 438 // EDI: data.
437 // Compare length with capacity. 439 // Compare length with capacity.
438 __ cmpl(EBX, FieldAddress(EDI, GrowableObjectArray::length_offset())); 440 __ cmpl(EBX, FieldAddress(EDI, GrowableObjectArray::length_offset()));
(...skipping 954 matching lines...) Expand 10 before | Expand all | Expand 10 after
1393 __ Bind(&is_true); 1395 __ Bind(&is_true);
1394 __ LoadObject(EAX, bool_true); 1396 __ LoadObject(EAX, bool_true);
1395 __ ret(); 1397 __ ret();
1396 return true; 1398 return true;
1397 } 1399 }
1398 1400
1399 #undef __ 1401 #undef __
1400 } // namespace dart 1402 } // namespace dart
1401 1403
1402 #endif // defined TARGET_ARCH_IA32 1404 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/intrinsifier_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698