chrome/browser/intents/device_attached_intent_source.cc - Issue 10871049: Connect MediaFileSystemRegistry with MediaGalleriesPreferences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/intents/device_attached_intent_source.cc

Issue 10871049: Connect MediaFileSystemRegistry with MediaGalleriesPreferences (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Self review Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/intents/device_attached_intent_source.cc

diff --git a/chrome/browser/intents/device_attached_intent_source.cc b/chrome/browser/intents/device_attached_intent_source.cc

index 7f874e7f40befebdcb04504d3b266e450c889ed0..101afc5cfd3cd6ada91b6b1a2a8fd44d431462c3 100644

--- a/chrome/browser/intents/device_attached_intent_source.cc

+++ b/chrome/browser/intents/device_attached_intent_source.cc

@@ -102,9 +102,7 @@ void DeviceAttachedIntentSource::OnRemovableStorageAttached(

// Only handle mass storage for now.

// TODO(kmadhusu): Handle all device types. http://crbug.com/140353.

- MediaStorageUtil::Type type;

- MediaStorageUtil::CrackDeviceId(id, &type, NULL);

- if (type == MediaStorageUtil::MTP_OR_PTP)

+ if (!MediaStorageUtil::IsMassStorageDevice(id))

return;

DCHECK(MediaStorageUtil::IsRemovableDevice(id));

Lei Zhang 2012/09/04 23:38:51 I think you need to remove this?

vandebo (ex-Chrome) 2012/09/05 00:58:12 Why? Device attach intent should only trigger for