Connect MediaFileSystemRegistry with MediaGalleriesPreferences

chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Media Galleries API.
 
 #include "chrome/browser/extensions/api/media_galleries/media_galleries_api.h"
 
 #include <string>
 #include <vector>
@@ skipping 52 matching lines @@
 
   error_ = kInvalidInteractive;
   return false;
 }
 
 void MediaGalleriesGetMediaFileSystemsFunction::ReturnGalleries() {
   const content::RenderProcessHost* rph = render_view_host()->GetProcess();
   chrome::MediaFileSystemRegistry* media_fs_registry =
       MediaFileSystemRegistry::GetInstance();
   const std::vector<MediaFileSystemRegistry::MediaFSInfo> filesystems =
       media_fs_registry->GetMediaFileSystemsForExtension(rph, *GetExtension());

[Lei Zhang, 2012/08/24 04:39:04]

Don't you need to pass in a rvh instead of a rph?

I'm trying to implement "chrome.mediaGalleries.registerForMediaFileSystemChange"
and I realized I need a place to store the registered callbacks. Maybe
MediaFileSystemRegistry is the place to do it?

[vandebo (ex-Chrome), 2012/09/04 21:02:20]

Done.
Sounds pretty reasonable.

 
   const int child_id = rph->GetID();
   base::ListValue* list = new base::ListValue();
   for (size_t i = 0; i < filesystems.size(); i++) {
     base::DictionaryValue* dict_value = new base::DictionaryValue();
     dict_value->SetWithoutPathExpansion(
         "fsid", Value::CreateStringValue(filesystems[i].fsid));
     // The directory name is not exposed to the js layer.
     dict_value->SetWithoutPathExpansion(
         "name", Value::CreateStringValue(filesystems[i].name));
     list->Append(dict_value);
 
-    if (GetExtension()->HasAPIPermission(
+    if (!filesystems[i].path.empty() && GetExtension()->HasAPIPermission(
             extensions::APIPermission::kMediaGalleriesRead)) {
       content::ChildProcessSecurityPolicy* policy =
           ChildProcessSecurityPolicy::GetInstance();
       if (!policy->CanReadFile(child_id, filesystems[i].path))
         policy->GrantReadFile(child_id, filesystems[i].path);
       policy->GrantReadFileSystem(child_id, filesystems[i].fsid);
     }
     // TODO(vandebo) Handle write permission.
   }
 
@@ skipping 24 matching lines @@
 MediaGalleriesAssembleMediaFileFunction::
     ~MediaGalleriesAssembleMediaFileFunction() {}
 
 bool MediaGalleriesAssembleMediaFileFunction::RunImpl() {
   // TODO(vandebo) Update the metadata and return the new file.
   SetResult(Value::CreateNullValue());
   return true;
 }
 
 }  // namespace extensions