chrome/browser/extensions/extension_function.h - Issue 10871034: Make all quota-exceeding messages in the storage API explain what the failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function.h

Issue 10871034: Make all quota-exceeding messages in the storage API explain what the failure (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update... the other error message Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/browser/extensions/extension_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_function.h

diff --git a/chrome/browser/extensions/extension_function.h b/chrome/browser/extensions/extension_function.h

index adef96a26b2bea8172565f9969be275a86001b7d..110d1713f7a3e2447161a19464d271e98b6393fe 100644

--- a/chrome/browser/extensions/extension_function.h

+++ b/chrome/browser/extensions/extension_function.h

@@ -118,7 +118,7 @@ class ExtensionFunction

// Called when the quota limit has been exceeded. The default implementation

// returns an error.

- virtual void OnQuotaExceeded();

+ virtual void OnQuotaExceeded(const std::string& violation_error);

// Specifies the raw arguments to the function, as a JSON value.

virtual void SetArgs(const base::ListValue* args);

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/browser/extensions/extension_function.cc » ('j') | no next file with comments »