Make all quota-exceeding messages in the storage API explain what the failure

chrome/browser/bookmarks/bookmark_extension_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/bookmark_extension_api.h"
 
 #include "base/bind.h"
 #include "base/file_path.h"
 #include "base/i18n/file_util_icu.h"
 #include "base/i18n/time_formatting.h"
@@ skipping 787 matching lines @@
   // For bookmarks.remove.
   static void BuildForRemove(QuotaLimitHeuristics* heuristics,
                              Profile* profile) {
     BuildWithMappers(heuristics, new RemoveBookmarksBucketMapper(profile),
                                  new RemoveBookmarksBucketMapper(profile));
   }
 
  private:
   static void BuildWithMappers(QuotaLimitHeuristics* heuristics,
       BucketMapper* short_mapper, BucketMapper* long_mapper) {
-    const Config kShortLimitConfig = {
-      2,                         // 2 tokens per interval.
-      TimeDelta::FromMinutes(1)  // 1 minute long refill interval.
+    const Config kSustainedLimitConfig = {
+      // See bookmarks.json for current value.
+      bookmarks::MAX_SUSTAINED_WRITE_OPERATIONS_PER_MINUTE,
+      TimeDelta::FromMinutes(1)
     };
-    const Config kLongLimitConfig = {
-      100,                       // 100 tokens per interval.
-      TimeDelta::FromHours(1)    // 1 hour long refill interval.
+    heuristics->push_back(new SustainedLimit(
+        TimeDelta::FromMinutes(10),
+        kSustainedLimitConfig,
+        short_mapper,
+        "MAX_SUSTAINED_WRITE_OPERATIONS_PER_MINUTE"));
+
+    const Config kTimedLimitConfig = {
+      // See bookmarks.json for current value.
+      bookmarks::MAX_WRITE_OPERATIONS_PER_HOUR,
+      TimeDelta::FromHours(1)
     };
-
-    TimedLimit* timed = new TimedLimit(kLongLimitConfig, long_mapper);
-    // A max of two operations per minute, sustained over 10 minutes.
-    SustainedLimit* sustained = new SustainedLimit(TimeDelta::FromMinutes(10),
-        kShortLimitConfig, short_mapper);
-    heuristics->push_back(timed);
-    heuristics->push_back(sustained);
+    heuristics->push_back(new TimedLimit(
+        kTimedLimitConfig,
+        long_mapper,
+        "MAX_WRITE_OPERATIONS_PER_HOUR"));
   }
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(BookmarksQuotaLimitFactory);
 };
 
 // And finally, building the individual heuristics for each function.
 void RemoveBookmarkFunction::GetQuotaLimitHeuristics(
     QuotaLimitHeuristics* heuristics) const {
   BookmarksQuotaLimitFactory::BuildForRemove(heuristics, profile());
 }
@@ skipping 119 matching lines @@
                                            int index,
                                            void* params) {
 #if !defined(OS_ANDROID)
   // Android does not have support for the standard exporter.
   // TODO(jgreenwald): remove ifdef once extensions are no longer built on
   // Android.
   bookmark_html_writer::WriteBookmarks(profile(), path, NULL);
 #endif
   Release();  // Balanced in BookmarksIOFunction::SelectFile()
 }