Issue 10871013: Add !defined(OS_IOS) to if defined(OS_MACOS) around functions GetSandboxProfileForSandboxType and G…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10871013: Add !defined(OS_IOS) to if defined(OS_MACOS) around functions GetSandboxProfileForSandboxType and G… (Closed)

Created:
8 years, 4 months ago by leng

Modified:
8 years, 3 months ago

Reviewers:
stuartmorgan, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add !defined(OS_IOS) to if defined(OS_MACOS) around functions GetSandboxProfileForSandboxType and GetCarbonInterposePath. These functions are not applicable to iOS. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153565

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	chrome/common/chrome_content_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_content_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

LGTM +jam for owners (For background, our OS_ targets mirror the way Apple does its ...

8 years, 4 months ago (2012-08-22 14:16:50 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/10871013/1

8 years, 3 months ago (2012-08-27 19:48:47 UTC) #5

Change committed as 153565

Expand Messages | Collapse Messages