Move common app_list delegate code to chrome/browser/ui/app_list.

Move common app_list delegate code to chrome/browser/ui/app_list.

This code previously lived in chrome/browser/ui/ash/app_list. The ash-specific controller code has not been moved.

BUG=138632
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153178

[xiyuan, 2012-08-22 16:25:52]

LGTM

[benwells, 2012-08-23 00:52:04]

beng: ping :)

[benwells, 2012-08-23 11:54:28]

Sorry, I just ran the try jobs on this and noticed a problem. I've uploaded
something which will hopefully fix it - adding the app_list dll dependency to
all targets - but this feels like overkill.

As an alternative to this I could only add the app_list files to the ash target,
and then when windows support comes (once this lands) add them to windows as
well. Is there a preferred way option for things like this?

[benwells, 2012-08-23 12:42:36]

On 2012/08/23 11:54:28, benwells wrote:
> Sorry, I just ran the try jobs on this and noticed a problem. I've uploaded
> something which will hopefully fix it - adding the app_list dll dependency to
> all targets - but this feels like overkill.
> 
> As an alternative to this I could only add the app_list files to the ash
target,
> and then when windows support comes (once this lands) add them to windows as
> well. Is there a preferred way option for things like this?

Looks like the try jobs have spoken ... app_list depends on views which won't
work on mac, linux, android. I'll split the files and dependencies just to the
ash port tomorrow.

[xiyuan, 2012-08-23 17:23:05]

On 2012/08/23 12:42:36, benwells wrote:
> On 2012/08/23 11:54:28, benwells wrote:
> > Sorry, I just ran the try jobs on this and noticed a problem. I've uploaded
> > something which will hopefully fix it - adding the app_list dll dependency
to
> > all targets - but this feels like overkill.
> > 
> > As an alternative to this I could only add the app_list files to the ash
> target,
> > and then when windows support comes (once this lands) add them to windows as
> > well. Is there a preferred way option for things like this?
> 
> Looks like the try jobs have spoken ... app_list depends on views which won't
> work on mac, linux, android. I'll split the files and dependencies just to the
> ash port tomorrow.

Sorry that was missed from my review. I tends to only thinking about chromeos.
:p

We usually use gyp condition and source pattern to include/exclude files from a
build. Think you could add 'sources/' : [ ['include', '/app_list/'] ] to
'use_ash==1' condition to include the files for ash. And add a exclude rule for
other platforms.

Another option would be update src/build/filename_rules.gypi, and for now, we
could exclude all "/app_list/" files when use_ash == 0.

[Ben Goodger (Google), 2012-08-23 19:57:45]

lgtm

[commit-bot: I haz the power, 2012-08-24 03:41:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/10871011/2062

[commit-bot: I haz the power, 2012-08-24 09:59:18]

Change committed as 153178