Make ClassFinalizer indifferent on whether we are generating a snapshot or not.

runtime/vm/dart_api_impl.cc

Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc	(revision 11113)
+++ runtime/vm/dart_api_impl.cc	(working copy)
@@ -88,9 +88,8 @@
 const char* CheckIsolateState(Isolate* isolate, bool generating_snapshot) {
   bool success = true;
   if (!ClassFinalizer::AllClassesFinalized()) {
-    success = (generating_snapshot) ?
-        ClassFinalizer::FinalizePendingClassesForSnapshotCreation() :
-        ClassFinalizer::FinalizePendingClasses();
+    ClassFinalizer class_finalizer(generating_snapshot);
+    success = class_finalizer.FinalizePendingClasses();
   }
   if (success) {
     success = isolate->object_store()->PreallocateObjects();
@@ -3727,7 +3726,8 @@
   const Script& script =
       Script::Handle(isolate, Script::New(url, source, kind));
   ASSERT(isolate != NULL);
-  const Error& error = Error::Handle(isolate, Compiler::Compile(lib, script));
+  const Error& error = Error::Handle(isolate, Compiler::Compile(
+      lib, script, ClassFinalizer::kNotGeneratingSnapshot));
   if (error.IsNull()) {
     *result = Api::NewHandle(isolate, lib.raw());
     if (update_lib_status) {