Extensions Docs Server: Testing GithubFileSystem and cron jobs

chrome/common/extensions/docs/server2/github_file_system.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import os
 
 import appengine_blobstore as blobstore
 import object_store
 from file_system import FileSystem, StatInfo
@@ skipping 11 matching lines @@
     self._fetch = fetcher.FetchAsync(ZIP_KEY)
     self._blobstore = blobstore
     self._new_version = new_version
     self._old_version = old_version
 
   def Get(self):
     blob = self._fetch.Get().content
     self._blobstore.Set(_MakeKey(self._new_version),
                         blob,
                         blobstore.BLOBSTORE_GITHUB)
-    self._blobstore.Delete(_MakeKey(self._old_version),
-                           blobstore.BLOBSTORE_GITHUB)
+    if self._old_version != self._new_version:

[not at google - send to devlin, 2012/08/22 13:57:58]

This "old version" vs "new version" thing is a bit weird when they can be the
same.

Would prefer if the arguments were like "key to set" and "key to delete
afterwards", the latter being optional.

[cduvall, 2012/08/22 17:20:43]

Done.

+      self._blobstore.Delete(_MakeKey(self._old_version),
+                             blobstore.BLOBSTORE_GITHUB)
     return ZipFile(BytesIO(blob))
 
 class GithubFileSystem(FileSystem):
   """FileSystem implementation which fetches resources from github.
   """
   def __init__(self, fetcher, object_store, blobstore):
     self._fetcher = fetcher
     self._object_store = object_store
     self._blobstore = blobstore
     self._version = self.Stat(ZIP_KEY).version
@@ skipping 31 matching lines @@
       self._GetZip(version)
     result = {}
     for path in paths:
       if path.endswith('/'):
         result[path] = self._ListDir(path)
       else:
         result[path] = self._ReadFile(path)
     return Future(value=result)
 
   def Stat(self, path):
-    version = self._object_store.Get(path, object_store.GITHUB_STAT)
+    version = self._object_store.Get(path, object_store.GITHUB_STAT).Get()
     if version is not None:
       return StatInfo(version)
     version = json.loads(
         self._fetcher.Fetch('commits/HEAD').content)['commit']['tree']['sha']
     self._object_store.Set(path, version, object_store.GITHUB_STAT)
     return StatInfo(version)