Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: src/untrusted/pnacl_irt_shim/nacl.scons

Issue 10870109: Change the pnacl shim from doing real shimming to just intercepting (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/untrusted/pnacl_irt_shim/shim_entry.c » ('j') | src/untrusted/pnacl_irt_shim/shim_entry.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/untrusted/pnacl_irt_shim/nacl.scons
===================================================================
--- src/untrusted/pnacl_irt_shim/nacl.scons (revision 9574)
+++ src/untrusted/pnacl_irt_shim/nacl.scons (working copy)
@@ -1,5 +1,5 @@
# -*- python -*-
-# Copyright (c) 2012 The Native Client Authors. All rights reserved.
+# Copyright 2012 The Native Client Authors. All rights reserved.
Mark Seaborn 2012/08/28 16:04:51 As in the other change, you don't need to remove t
Robert Muth (chromium) 2012/08/28 19:11:24 Done.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -12,33 +12,15 @@
if not env.Bit('bitcode') or not env.Bit('target_x86_64'):
Return()
-# The library must be compiled with nacl-gcc.
# Clear out the pnacl_generate_pexe bit to allow building this as a
# library dependency (much like the IRT).
-nacl_gcc_env = env.Clone()
-nacl_gcc_env.ClearBits('pnacl_generate_pexe')
-nacl_gcc_env = nacl_gcc_env.PNaClGetNNaClEnv()
+env.ClearBits('pnacl_generate_pexe')
-# Generate a 'pnacl_shim.c'
-api_glob = env.Glob('${SOURCE_ROOT}/ppapi/api/*.idl')
-api_dev_glob = env.Glob('${SOURCE_ROOT}/ppapi/api/dev/*.idl')
-generators_glob = env.Glob('${SOURCE_ROOT}/ppapi/generators/*.py')
-generated_file_c = nacl_gcc_env.Command(
- 'pnacl_shim.c',
- (api_glob + api_dev_glob + generators_glob),
- ('${PYTHON} ' +
- '${SOURCE_ROOT}/ppapi/generators/generator.py ' +
- '--srcroot=' + os.path.join('${SOURCE_ROOT}', 'ppapi', 'api') + ' ' +
- '--wnone --pnacl --pnaclshim=${TARGETS} ' +
- ' '.join([idl_file.abspath for idl_file in api_glob + api_dev_glob])))
-
-pnacl_irt_shim = nacl_gcc_env.ComponentLibrary('pnacl_irt_shim', [
- generated_file_c,
+pnacl_irt_shim = env.ComponentLibrary('pnacl_irt_shim', [
'shim_entry.c',
- 'shim_ppapi.c',
])
-# However, the library is part of the pnacl sdk (use original env).
+# The library is part of the pnacl toolchain
env.AddLibraryToSdk(pnacl_irt_shim)
env.AddObjectToSdk(['libpnacl_irt_shim.a'])
« no previous file with comments | « no previous file | src/untrusted/pnacl_irt_shim/shim_entry.c » ('j') | src/untrusted/pnacl_irt_shim/shim_entry.c » ('J')

Powered by Google App Engine
This is Rietveld 408576698