Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 10870108: Revert "Add a new API V8::SetJitCodeEventHandler to push code name and location to users such as pr… (Closed)

Created:
8 years, 3 months ago by Toon Verwaest
Modified:
8 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
Sigurður Ásgeirsson, v8-dev
Visibility:
Public.

Description

Revert "Add a new API V8::SetJitCodeEventHandler to push code name and location to users such as profilers." This reverts commit r12389. TBR=jkummerow@chromium.org, CC=siggi@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -432 lines) Patch
M include/v8.h View 2 chunks +0 lines, -74 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/cpu-profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/log.h View 5 chunks +0 lines, -25 lines 0 comments Download
M src/log.cc View 13 chunks +13 lines, -96 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/serialize.cc View 2 chunks +21 lines, -37 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -184 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Jakob Kummerow
8 years, 3 months ago (2012-08-27 19:46:30 UTC) #1
rubberstamp LGTM. Thanks.

Powered by Google App Engine
This is Rietveld 408576698