Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 10870104: Fix max/min window menu items by calling the correct version of EnableMenuItem. (Closed)

Created:
8 years, 3 months ago by Ben Goodger (Google)
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix max/min window menu items by calling the correct version of EnableMenuItem. I moved the code that enabled these items to HWNDMessageHandler, but forgot to move the definition of the function. This wasn't a compile error because Win32 defines the same function with the same signature, in the global namespace. DOH! I renamed the helper function to a unique name: EnableMenuItembyCommand to prevent this from happening again. This change also moves ScopedRedrawLock to the top of the file, since it needs to be called in onInitMenu also. http://crbug.com/144425 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -70 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 4 chunks +78 lines, -70 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
8 years, 3 months ago (2012-08-27 17:27:24 UTC) #1
sky
8 years, 3 months ago (2012-08-27 17:30:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698