Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Issue 10870103: Remove no longer used NetNanny and ESET anti-virus error (Closed)

Created:
8 years, 3 months ago by mmenke
Modified:
8 years, 3 months ago
Reviewers:
Nico, agl
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Reland of http://codereview.chromium.org/10877025/. Accidentally included other code in the CL when manually landing after the CQ got stuck, so had to revert (See http://codereview.chromium.org/10880048/) Remove no longer used NetNanny and ESET anti-virus error strings and ESET error code. TBR=agl@chromium.org, thakis@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -64 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -48 lines 0 comments Download
M chrome/common/localized_error.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M net/base/net_error_list.h View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
commit-bot: I haz the power
No reviewers yet.
8 years, 3 months ago (2012-08-27 17:31:03 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 3 months ago (2012-08-27 17:32:12 UTC) #2
mmenke
Hmm...Thought TBR would allow a land. Thakis: Could you sign off on this again? It's ...
8 years, 3 months ago (2012-08-27 17:33:30 UTC) #3
Nico
On 2012/08/27 17:33:30, Matt Menke wrote: > Hmm...Thought TBR would allow a land. It does, ...
8 years, 3 months ago (2012-08-27 19:36:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10870103/1
8 years, 3 months ago (2012-08-27 19:41:16 UTC) #5
mmenke
On 2012/08/27 19:36:49, Nico wrote: > On 2012/08/27 17:33:30, Matt Menke wrote: > > Hmm...Thought ...
8 years, 3 months ago (2012-08-27 19:44:12 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 22:28:11 UTC) #7
Change committed as 153564

Powered by Google App Engine
This is Rietveld 408576698