Issue 10870098: [FileBrowser] Fixed default action context menu item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10870098: [FileBrowser] Fixed default action context menu item (Closed)

Created:
8 years, 3 months ago by Dmitry Zvorygin

Modified:
8 years, 3 months ago

Reviewers:
dgozman

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[FileBrowser] Fixed default action context menu item. BUG=140909 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153473

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed comment. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -9 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager.js	View	1	1 chunk	+20 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

dgozman

8 years, 3 months ago (2012-08-27 13:07:10 UTC) #1

LGTM with fix

https://chromiumcodereview.appspot.com/10870098/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10870098/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:4204:
this.actionNode_.style.backgroundImage = '';
actionNode_ ?

Expand Messages | Collapse Messages