Add SPDY request headers to DevTools.

chrome/test/data/webui/net_internals/log_view_painter.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Include test fixture.
 GEN_INCLUDE(['net_internals_test.js']);
 
 // Anonymous namespace
 (function() {
 
@@ skipping 44 matching lines @@
     ['Proxy-Authenticate: Kerberos,Digest,Basic', null],
     ['Proxy-Authenticate: Digest realm="asdfasdf", nonce=5, qop="auth"', null],
     ['Proxy-Authenticate: Basic realm=foo,foo=bar , Digest ', null]
   ];
 
   for (var i = 0; i < expectations.length; ++i) {
     var expectation = expectations[i];
     // Position within params.headers where the authentication information goes.
     for (var position = 0; position < 3; ++position) {
       var entry = {
-          'params': {
-              'headers': [
-                  'Host: clients1.google.com',
-                  'Connection: keep-alive',
-                  'User-Agent: Mozilla/5.0'],
-              'line': 'GET / HTTP/1.1\r\n'},
-          'phase': 0,
-          'source': {'id': 329, 'type': 1},
-          'time': '22468349',
-          'type': 104};
+        'params': {
+          'headers': [
+            'Host: clients1.google.com',
+            'Connection: keep-alive',
+            'User-Agent: Mozilla/5.0'
+          ],
+          'line': 'GET / HTTP/1.1\r\n'
+        },
+        'phase': EventPhase.PHASE_BEGIN,
+        'source': {'id': 329, 'type': EventSourceType.URL_REQUEST},
+        'time': '22468349',
+        'type': EventSourceType.URL_REQUEST
+      };
 
       entry.params.headers[position] = expectation[0];
       var stripped = stripCookiesAndLoginInfo(entry);
       // The entry should be duplicated, so the original still has the deleted
       // information.
       expectNotEquals(stripped, entry);
       if (expectation[1] == null) {
-        expectEquals(stripped.params.headers[position], expectation[0]);
+        expectEquals(expectation[0], stripped.params.headers[position]);
       } else {
-        expectEquals(stripped.params.headers[position], expectation[1]);
+        expectEquals(expectation[1], stripped.params.headers[position]);
       }
     }
   }
+
+  // Test with SPDY request headers, which use an object rather than an array.
+  var spdyRequestHeadersEntry = {
+    'params': {
+      'headers': {
+        ':host': 'clients1.google.com',
+        ':method': 'GET',
+        ':path': '/cute/cat/pictures/',
+        'cookie': 'blah'
+       },
+      'line': 'GET / HTTP/1.1\r\n'
+    },
+    'phase': EventPhase.PHASE_BEGIN,
+    'source': {'id': 329, 'type': EventSourceType.URL_REQUEST},
+    'time': '22468349',
+    'type': EventSourceType.HTTP_TRANSACTION_SPDY_SEND_REQUEST_HEADERS
+  };
+  var strippedSpdyRequestHeadersEntry =
+      stripCookiesAndLoginInfo(spdyRequestHeadersEntry);
+  expectEquals('cookie: [value was stripped]',
+               strippedSpdyRequestHeadersEntry.params.headers[3]);
+
   testDone();
 });
 
 /**
  * Tests the formatting of log entries to fixed width text.
  */
 TEST_F('NetInternalsTest', 'netInternalsLogViewPainterPrintAsText', function() {
   // Add a DOM node to draw the log entries into.
   var div = addNode(document.body, 'div');
 
@@ skipping 18 matching lines @@
   runTestCase(painterTestURLRequestIncomplete());
   runTestCase(painterTestURLRequestIncompleteFromLoadedLog());
   runTestCase(painterTestNetError());
   runTestCase(painterTestHexEncodedBytes());
   runTestCase(painterTestCertVerifierJob());
   runTestCase(painterTestProxyConfig());
   runTestCase(painterTestDontStripCookiesURLRequest());
   runTestCase(painterTestStripCookiesURLRequest());
   runTestCase(painterTestDontStripCookiesSPDYSession());
   runTestCase(painterTestStripCookiesSPDYSession());
+  runTestCase(painterTestSpdyURLRequestDontStripCookies());
+  runTestCase(painterTestSpdyURLRequestStripCookies());
   runTestCase(painterTestExtraCustomParameter());
   runTestCase(painterTestMissingCustomParameter());
   runTestCase(painterTestSSLVersionFallback());
 
   testDone();
 });
 
 /**
  * Test case for a URLRequest. This includes custom formatting for load flags,
  * request/response HTTP headers, dependent sources, as well as basic
@@ skipping 1332 matching lines @@
  */
 function painterTestStripCookiesSPDYSession() {
   var testCase = painterTestDontStripCookiesSPDYSession();
   testCase.privacyStripping = true;
   testCase.expectedText =
       testCase.expectedText.replace(/MyLittlePony/g, '[value was stripped]');
   return testCase;
 }
 
 /**
+ * Tests that cookies are NOT stripped from SPDY URL request headers when
+ * stripping is not enabled. The difference from the above requests is that SPDY
+ * URL request headers use dictionaries rather than lists.
+ */
+function painterTestSpdyURLRequestDontStripCookies() {
+  var testCase = {};
+  testCase.tickOffset = '1337911098481';
+
+  testCase.logEntries = [
+    {
+      'params': {
+          'headers': {
+            ':host': 'www.google.com',
+            ':method': 'GET',
+            ':path': '/',
+            ':scheme': 'https',
+            ':version': 'HTTP/1.1',
+            'cookie': 'MyMagicPony'},
+      },
+      'phase': EventPhase.PHASE_NONE,
+      'source': {'id': 329, 'type': EventSourceType.URL_REQUEST},
+      'time': '954124663',
+      'type': EventType.HTTP_TRANSACTION_SPDY_SEND_REQUEST_HEADERS
+    }
+  ];
+
+  testCase.expectedText =
+'t=1338865223144 [st=0]  HTTP_TRANSACTION_SPDY_SEND_REQUEST_HEADERS\n' +
+'                        --> :host: www.google.com\n' +
+'                            :method: GET\n' +
+'                            :path: /\n' +
+'                            :scheme: https\n' +
+'                            :version: HTTP/1.1\n' +
+'                            cookie: MyMagicPony';
+  return testCase;
+}
+
+/**
+ * Tests that cookies are NOT stripped from SPDY URL request headers when
+ * stripping is not enabled. The difference from the above requests is that
+ */
+function painterTestSpdyURLRequestStripCookies() {
+  var testCase = painterTestSpdyURLRequestDontStripCookies();
+  testCase.privacyStripping = true;
+  testCase.expectedText =
+      testCase.expectedText.replace(/MyMagicPony/g, '[value was stripped]');
+  return testCase;
+}
+
+/**
  * Tests that when there are more custom parameters than we expect for an
  * event type, they are printed out in addition to the custom formatting.
  */
 function painterTestExtraCustomParameter() {
   var testCase = {};
   testCase.tickOffset = '1337911098446';
 
   testCase.logEntries = [
     {
       'params': {
@@ skipping 124 matching lines @@
 '                          --> TLS 1.0 ==> SSL 3.0\n' +
 '                          --> host_and_port = "www-927.ibm.com:443"\n' +
 '                          --> net_error = -107 (ERR_SSL_PROTOCOL_ERROR)\n' +
 't=1339030161250 [st=171]  SSL_VERSION_FALLBACK\n' +
 '                          --> SSL 3.0 ==> SSL 0x123456';
 
   return testCase;
 }
 
 })();  // Anonymous namespace