Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 10870077: Merge 126042 - [chromium] pepper plugins sometimes are shifted by 1 pixel (Closed)

Created:
8 years, 4 months ago by karen
Modified:
8 years, 4 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 126042 - [chromium] pepper plugins sometimes are shifted by 1 pixel https://bugs.webkit.org/show_bug.cgi?id=94257 Patch by Yuzhu Shen <yzshen@chromium.com>; on 2012-08-20 Reviewed by Levi Weintraub. Change RenderWidget::updateWidgetGeometry() to use LayoutRect instead of IntRect to avoid unwanted truncation (when converting from FloatRect to IntRect). This makes sure that the optimized rendering code path of Pepper plugin (PluginInstance::GetBitmapForOptimizedPluginPaint) has consistent coordinates with the normal WebKit rendering code path. No new tests because we don't have Pepper plugin tests in WebKit. * rendering/RenderWidget.cpp: (WebCore::RenderWidget::updateWidgetGeometry): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/WebCore/rendering/RenderWidget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 4 months ago (2012-08-24 19:44:12 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698