Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 10870066: Support unary - operator. (Closed)

Created:
8 years, 4 months ago by ahe
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org, Johnni Winther, Lasse Reichstein Nielsen, hausner
Visibility:
Public.

Description

Support unary - operator. Committed: https://code.google.com/p/dart/source/detail?r=11444 (first attempt failed) Committed: https://code.google.com/p/dart/source/detail?r=11496

Patch Set 1 #

Patch Set 2 : Handle x.negate() as before #

Patch Set 3 : Rebased #

Patch Set 4 : Fix mirrors #

Patch Set 5 : Restore "negate" interceptor #

Total comments: 1

Patch Set 6 : Fix unparser to handle that negate is no longer a keyword. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -76 lines) Patch
M dart/lib/compiler/implementation/elements/elements.dart View 1 2 3 1 chunk +46 lines, -24 lines 0 comments Download
M dart/lib/compiler/implementation/lib/interceptors.dart View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M dart/lib/compiler/implementation/scanner/class_element_parser.dart View 2 chunks +27 lines, -17 lines 0 comments Download
M dart/lib/compiler/implementation/scanner/keyword.dart View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M dart/lib/compiler/implementation/scanner/parser.dart View 1 chunk +3 lines, -1 line 0 comments Download
M dart/lib/compiler/implementation/scanner/token.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M dart/lib/compiler/implementation/ssa/builder.dart View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M dart/lib/compiler/implementation/tree/unparser.dart View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M dart/lib/compiler/implementation/universe.dart View 1 2 2 chunks +12 lines, -14 lines 0 comments Download
M dart/pkg/dartdoc/mirrors/dart2js_mirror.dart View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M dart/tests/co19/co19-dart2js.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M dart/tests/compiler/dart2js/mirrors_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/parser_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/resolver_test.dart View 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
I also tried changing the corelib to use operator- instead of operator negate. It seems ...
8 years, 4 months ago (2012-08-24 12:58:08 UTC) #1
ngeoffray
LGTM!
8 years, 4 months ago (2012-08-24 15:50:43 UTC) #2
ahe
PTAL. I reverted the first attempt at submitting this change. I have figured out what ...
8 years, 3 months ago (2012-08-28 14:33:01 UTC) #3
ngeoffray
LGTM
8 years, 3 months ago (2012-08-28 15:31:19 UTC) #4
ahe
Hi Anton, Could you take a look at the changes to unparser.dart? Cheers, Peter
8 years, 3 months ago (2012-08-28 16:06:26 UTC) #5
ahe
8 years, 3 months ago (2012-08-29 08:21:50 UTC) #6
Thank you, Anton and Nicolas!

Powered by Google App Engine
This is Rietveld 408576698