Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: chrome/browser/history/history_database_unittest.cc

Issue 10870029: Remove legacy migration code that coupled history and bookmarks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More android fixes. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_database.cc ('k') | chrome/browser/history/starred_url_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_database_unittest.cc
diff --git a/chrome/browser/history/history_database_unittest.cc b/chrome/browser/history/history_database_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..711b94a69f286851c79a2f05c60f44eecd96c334
--- /dev/null
+++ b/chrome/browser/history/history_database_unittest.cc
@@ -0,0 +1,49 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/history/history_database.h"
+
+#include "base/file_path.h"
+#include "base/file_util.h"
+#include "base/path_service.h"
+#include "base/scoped_temp_dir.h"
+#include "chrome/common/chrome_paths.h"
+#include "sql/init_status.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace history {
+
+TEST(HistoryDatabaseTest, DropBookmarks) {
+ ScopedTempDir temp_dir;
+ FilePath db_file;
+
+ ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
+ db_file = temp_dir.path().AppendASCII("DropBookmarks.db");
+ file_util::Delete(db_file, false);
+
+ // Copy db file over that contains starred URLs.
+ FilePath old_history_path;
+ PathService::Get(chrome::DIR_TEST_DATA, &old_history_path);
+ old_history_path = old_history_path.AppendASCII("bookmarks");
+ old_history_path = old_history_path.Append(
+ FILE_PATH_LITERAL("History_with_starred"));
+ file_util::CopyFile(old_history_path, db_file);
+
+ // Load the DB twice. The first time it should migrate. Make sure that the
+ // migration leaves it in a state fit to load again later.
+ for (int i = 0; i < 2; ++i) {
+ HistoryDatabase history_db;
+ ASSERT_EQ(sql::INIT_OK, history_db.Init(db_file));
+ HistoryDatabase::URLEnumerator url_enumerator;
+ ASSERT_TRUE(history_db.InitURLEnumeratorForEverything(&url_enumerator));
+ int num_urls = 0;
+ URLRow url_row;
+ while (url_enumerator.GetNextURL(&url_row)) {
+ ++num_urls;
+ }
+ ASSERT_EQ(5, num_urls);
+ }
+}
+
+} // namespace history
« no previous file with comments | « chrome/browser/history/history_database.cc ('k') | chrome/browser/history/starred_url_database.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698