Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: chrome/browser/bookmarks/bookmark_html_writer.h

Issue 10870022: Change FaviconData to be able to return data for multiple bitmaps for same icon URL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_HTML_WRITER_H_ 5 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_HTML_WRITER_H_
6 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_HTML_WRITER_H_ 6 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_HTML_WRITER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 // Executes Writer task that writes bookmarks data to html file. 57 // Executes Writer task that writes bookmarks data to html file.
58 void ExecuteWriter(); 58 void ExecuteWriter();
59 59
60 // Starts async fetch for the next bookmark favicon. 60 // Starts async fetch for the next bookmark favicon.
61 // Takes single url from bookmark_urls_ and removes it from the list. 61 // Takes single url from bookmark_urls_ and removes it from the list.
62 // Returns true if there are more favicons to extract. 62 // Returns true if there are more favicons to extract.
63 bool FetchNextFavicon(); 63 bool FetchNextFavicon();
64 64
65 // Favicon fetch callback. After all favicons are fetched executes 65 // Favicon fetch callback. After all favicons are fetched executes
66 // html output on the file thread. 66 // html output on the file thread.
67 void OnFaviconDataAvailable(FaviconService::Handle handle, 67 void OnFaviconDataAvailable(
68 history::FaviconData favicon); 68 FaviconService::Handle handle,
69 const history::FaviconBitmapResult& bitmap_result);
69 70
70 // The Profile object used for accessing FaviconService, bookmarks model. 71 // The Profile object used for accessing FaviconService, bookmarks model.
71 Profile* profile_; 72 Profile* profile_;
72 73
73 // All URLs that are extracted from bookmarks. Used to fetch favicons 74 // All URLs that are extracted from bookmarks. Used to fetch favicons
74 // for each of them. After favicon is fetched top url is removed from list. 75 // for each of them. After favicon is fetched top url is removed from list.
75 std::list<std::string> bookmark_urls_; 76 std::list<std::string> bookmark_urls_;
76 77
77 // Consumer for requesting favicons. 78 // Consumer for requesting favicons.
78 CancelableRequestConsumer favicon_consumer_; 79 CancelableRequestConsumer favicon_consumer_;
(...skipping 18 matching lines...) Expand all
97 // thread is used. 98 // thread is used.
98 // Before writing to the file favicons are fetched on the main thread. 99 // Before writing to the file favicons are fetched on the main thread.
99 // TODO(sky): need a callback on failure. 100 // TODO(sky): need a callback on failure.
100 void WriteBookmarks(Profile* profile, 101 void WriteBookmarks(Profile* profile,
101 const FilePath& path, 102 const FilePath& path,
102 BookmarksExportObserver* observer); 103 BookmarksExportObserver* observer);
103 104
104 } // namespace bookmark_html_writer 105 } // namespace bookmark_html_writer
105 106
106 #endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_HTML_WRITER_H_ 107 #endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_HTML_WRITER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_html_writer.cc » ('j') | chrome/browser/favicon/favicon_service.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698