Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Side by Side Diff: PRESUBMIT.py

Issue 10870014: Revert 152788 - Give access to browsers by Profile/HostDesktopType. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/app_controller_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 ( 140 (
141 'browser::FindLastActiveWithProfile', 141 'browser::FindLastActiveWithProfile',
142 ( 142 (
143 'This function is deprecated and we\'re working on removing it. Pass', 143 'This function is deprecated and we\'re working on removing it. Pass',
144 'more context to get a Browser*, like a WebContents, window, or session', 144 'more context to get a Browser*, like a WebContents, window, or session',
145 'id. Talk to ben@ or jam@ for more information.', 145 'id. Talk to ben@ or jam@ for more information.',
146 ), 146 ),
147 True, 147 True,
148 ), 148 ),
149 ( 149 (
150 'browser::FindBrowserWithProfile',
151 (
152 'This function is deprecated and we\'re working on removing it. Pass',
153 'more context to get a Browser*, like a WebContents, window, or session',
154 'id. Talk to ben@ or jam@ for more information.',
155 ),
156 True,
157 ),
158 (
150 'browser::FindAnyBrowser', 159 'browser::FindAnyBrowser',
151 ( 160 (
152 'This function is deprecated and we\'re working on removing it. Pass', 161 'This function is deprecated and we\'re working on removing it. Pass',
153 'more context to get a Browser*, like a WebContents, window, or session', 162 'more context to get a Browser*, like a WebContents, window, or session',
154 'id. Talk to ben@ or jam@ for more information.', 163 'id. Talk to ben@ or jam@ for more information.',
155 ), 164 ),
156 True, 165 True,
157 ), 166 ),
158 ( 167 (
159 'browser::FindOrCreateTabbedBrowser', 168 'browser::FindOrCreateTabbedBrowser',
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
590 599
591 # Match things like path/aura/file.cc and path/file_aura.cc. 600 # Match things like path/aura/file.cc and path/file_aura.cc.
592 # Same for ash and chromeos. 601 # Same for ash and chromeos.
593 if any(re.search('[/_](ash|aura)', f) for f in files): 602 if any(re.search('[/_](ash|aura)', f) for f in files):
594 trybots += ['linux_chromeos', 'linux_chromeos_clang:compile', 'win_aura'] 603 trybots += ['linux_chromeos', 'linux_chromeos_clang:compile', 'win_aura']
595 else: 604 else:
596 if any(re.search('[/_]chromeos', f) for f in files): 605 if any(re.search('[/_]chromeos', f) for f in files):
597 trybots += ['linux_chromeos', 'linux_chromeos_clang:compile'] 606 trybots += ['linux_chromeos', 'linux_chromeos_clang:compile']
598 607
599 return trybots 608 return trybots
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/app_controller_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698